Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hawk point support #281

Closed
wants to merge 4 commits into from
Closed

Hawk point support #281

wants to merge 4 commits into from

Conversation

ciphray
Copy link
Contributor

@ciphray ciphray commented Feb 20, 2024

enabled table parsing on hawk point
added table versions used in multiple phoenix point and hawk point devices

enabled table parsing on hawk point
added table versions used in multiple phoenix point and hawk point devices
@FlyGoat
Copy link
Owner

FlyGoat commented Feb 20, 2024

Hi,

Thanks for your work!
Could you please tidy up your changes? I can't review a PR that literally changed every line of that file.
If you are not familiar with git, you can also tell me where did you change the code and I can format them.

Thanks

@FlyGoat FlyGoat changed the title Add files via upload Hawk point support Feb 20, 2024
@ciphray
Copy link
Contributor Author

ciphray commented Feb 20, 2024

ah sorry, not familiar with github, lemme fix that and resubmit
when i edited the file it looks like all the line returns got changed somehow

Hawk Point read table enable
Table version 4c0007 and 4c0008 added to read values(Z1 and 7x40u and 8x40u devices)
Table version 4c0007 and 4c0008 added to read values (Z1 and 7x40u and 8x40u devices)
@FlyGoat
Copy link
Owner

FlyGoat commented Feb 20, 2024

To keep git history clean, I had committed those changes to https://github.com/FlyGoat/RyzenAdj/tree/dev/hawk branch, could you please help me check if they are correct?

@ciphray
Copy link
Contributor Author

ciphray commented Feb 20, 2024

2024-02-20 (2)
it does look to be reflecting the changes I made
I had removed the PPT Value APU as that seems to return a 0 on phoenix and hawk point (already reflected in the current file in the branch you made)
STT value APU also returns a 0, but both of those do reflect the correct values for limits, not sure if that could be something i have set in the bios causing that, or if that's the correct value STT should be reporting

@FlyGoat FlyGoat closed this Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants