Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic support for Strix Point #310

Closed
wants to merge 2 commits into from
Closed

Conversation

mzdluo123
Copy link
Contributor

This merge request contains basic support for strix point. The relevant information is obtained from the ryzen master software. It also contains some of guessed parameters. These parameters may not necessarily be correct. The purpose is to hope that someone can continue to develop.

CPU Family: Strix Point
SMU_SERVICE REQ_ID:0x3
SMU_SERVICE REQ: arg0: 0x0, arg1:0x0, arg2:0x0, arg3:0x0, arg4: 0x0, arg5: 0x0
SMU_SERVICE REP: REP: 0x1, arg0: 0x14, arg1:0x0, arg2:0x0, arg3:0x0, arg4: 0x0, arg5: 0x0
SMU BIOS Interface Version: 20
Version: v0.15.0
init_table
SMU_SERVICE REQ_ID:0x6
SMU_SERVICE REQ: arg0: 0x0, arg1:0x0, arg2:0x0, arg3:0x0, arg4: 0x0, arg5: 0x0
SMU_SERVICE REP: REP: 0x1, arg0: 0x5d0008, arg1:0x0, arg2:0x0, arg3:0x0, arg4: 0x0, arg5: 0x0
SMU_SERVICE REQ_ID:0x66
SMU_SERVICE REQ: arg0: 0x0, arg1:0x0, arg2:0x0, arg3:0x0, arg4: 0x0, arg5: 0x0
SMU_SERVICE REP: REP: 0x1, arg0: 0x5e180000, arg1:0x8, arg2:0x0, arg3:0x0, arg4: 0x0, arg5: 0x0
SMU_SERVICE REQ_ID:0x65
SMU_SERVICE REQ: arg0: 0x0, arg1:0x0, arg2:0x0, arg3:0x0, arg4: 0x0, arg5: 0x0
SMU_SERVICE REP: REP: 0x1, arg0: 0x0, arg1:0x0, arg2:0x0, arg3:0x0, arg4: 0x0, arg5: 0x0
PM Table Version: 5d0008
SMU_SERVICE REQ_ID:0x65
SMU_SERVICE REQ: arg0: 0x0, arg1:0x0, arg2:0x0, arg3:0x0, arg4: 0x0, arg5: 0x0
SMU_SERVICE REP: REP: 0x1, arg0: 0x0, arg1:0x0, arg2:0x0, arg3:0x0, arg4: 0x0, arg5: 0x0
|        Name         |   Value   |     Parameter      |
|---------------------|-----------|--------------------|
| STAPM LIMIT         |    33.000 | stapm-limit        |
| STAPM VALUE         |     5.875 |                    |
| PPT LIMIT FAST      |    33.000 | fast-limit         |
| PPT VALUE FAST      |    17.084 |                    |
| PPT LIMIT SLOW      |    33.000 | slow-limit         |
| PPT VALUE SLOW      |     7.706 |                    |
| StapmTimeConst      |   800.000 | stapm-time         |
| SlowPPTTimeConst    |  2208.000 | slow-time          |
| PPT LIMIT APU       |    45.000 | apu-slow-limit     |
| PPT VALUE APU       |     0.000 |                    |
| TDC LIMIT VDD       |    45.000 | vrm-current        |
| TDC VALUE VDD       |     0.000 |                    |
| TDC LIMIT SOC       |     0.000 | vrmsoc-current     |
| TDC VALUE SOC       |     0.000 |                    |
| EDC LIMIT VDD       |     0.000 | vrmmax-current     |
| EDC VALUE VDD       |     0.000 |                    |
| EDC LIMIT SOC       |     3.874 | vrmsocmax-current  |
| EDC VALUE SOC       |    30.000 |                    |
| THM LIMIT CORE      |    95.000 | tctl-temp          |
| THM VALUE CORE      |    54.052 |                    |
| STT LIMIT APU       |    95.000 | apu-skin-temp      |
| STT VALUE APU       |    54.052 |                    |
| STT LIMIT dGPU      |    38.000 | dgpu-skin-temp     |
| STT VALUE dGPU      |    31.363 |                    |
| CCLK Boost SETPOINT |    51.260 | power-saving /     |
| CCLK BUSY VALUE     |    10.788 | max-performance    |

#define MP1_C2PMSG_MESSAGE_ADDR_3 0x3b10a20
#define MP1_C2PMSG_RESPONSE_ADDR_3 0x3b10a80
#define MP1_C2PMSG_ARG_BASE_3 0x3b10a88

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excessive new lines

@FlyGoat
Copy link
Owner

FlyGoat commented Sep 4, 2024

Good stuff!
How did you test service requests? Are you cross-checking with uProf?

Also, could you please separate formatting change with functional change, so git blame would be useful.

Thanks

@mzdluo123
Copy link
Contributor Author

For the data table, I have checked the power consumption and temperature with the data from HWMonitor, but I have not checked other items, and the way to obtain them is also guesswork.

For uProf, it seems that it cannot run on my computer.

For the power limit setting function, the program returns success, but it is not actually changed successfully. Maybe other programs on my computer prevent the change

@FlyGoat
Copy link
Owner

FlyGoat commented Sep 4, 2024

@mzdluo123 Thanks, that makes sense. If limit adjustment is not working, then please exclude it from the PR.

Btw do you mind providing a copy of ACPI dump for your system? I would like to check if ALIB method had changed.

@FlyGoat
Copy link
Owner

FlyGoat commented Sep 5, 2024

After going through ACPI dump from other sources I believe MP1 SMU address should be :

#define MP1_C2PMSG_MESSAGE_ADDR_3        0x3b10928
#define MP1_C2PMSG_RESPONSE_ADDR_3      0x3b10978
#define MP1_C2PMSG_ARG_BASE_3            0x3b10998

@FlyGoat
Copy link
Owner

FlyGoat commented Sep 5, 2024

Please check this branch:
https://github.com/FlyGoat/RyzenAdj/tree/stx-point

@FlyGoat
Copy link
Owner

FlyGoat commented Sep 5, 2024

Suppressed #311, thanks for your contribution!

@FlyGoat FlyGoat closed this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants