Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V1] [Social] Fix state bad URL characters #912

Merged
merged 2 commits into from
Apr 21, 2021
Merged

Conversation

LoicPoullain
Copy link
Member

Issue

Fixes #754.

Solution and steps

  • In AbstractProvider, generate base64url-encoded tokens.

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (v1-12-2@3e7ee2f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             v1-12-2     #912   +/-   ##
==========================================
  Coverage           ?   99.59%           
==========================================
  Files              ?       94           
  Lines              ?     1730           
  Branches           ?      391           
==========================================
  Hits               ?     1723           
  Misses             ?        7           
  Partials           ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e7ee2f...8db6ff7. Read the comment docs.

@LoicPoullain LoicPoullain merged commit 9f431c3 into v1-12-2 Apr 21, 2021
@LoicPoullain LoicPoullain deleted the v1-oauth2-base64url branch April 21, 2021 14:21
@LoicPoullain LoicPoullain mentioned this pull request Apr 21, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants