Hue Smart Button support #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloned the Switch object and configured it to work with the Smart Button. There was an icon already in the assets.
There was not enough info on the original 'sensor' object from the bridge to select the Button (due to Huejay not being updated for button), therefore added a new attribute to the sensor object using the model ID from the bridge JSON. (seemed only way).
(Do we need Huejay at all? Seems unmaintained).
This works now and removed the button presses not relevant to the Smart Button. Updated info text as well.
Works for me and doesn't seem to break anything. Please review/test!
NB the state 'holded' is incorrect English; changed to 'held' in the HTML, but not the message payload as it might break people's flows for the Switch, since message object is shared.
Hope I've done it all correctly, this is my first pull request.