Suppress on property name changed config #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM but for some reason the CI run timed out after one hour :/ |
|
build passed |
|
I can't edit the options wiki myself, if you're waiting for that. |
|
No worries, I'll update the wiki page once this PR is merged. Since you didn't merge it yet @SimonCropp I'll ask just in case: is this change OK for you? |
|
yep. lgtm |
|
I noticed a little detail (unfortunately after merging), when editing the wiki page: shouldn't we rename |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the missing config schema for
SuppressWarningsThis PR adds a new config
SuppressOnPropertyNameChangedFixes #539
Todos