Trimming output?

[barryo]

Hi!

Thanks for creating Foil. It solves a big issue I had with Plates: lack of multi-folder support and so creating skinnable templates with Plates was not possible.

One thing with Foil that keeps biting me is this line which is:

    private function doRender($path, array $data = [], $class = null)
    {
        // ...
        $output = trim($template->render($data));
        // ...
        return $output;
    }

Why trim()? Can this not be left up to the developer as desired? E.g. me! Or made an option? One of things we use foil for (as well as HTML templates) is building plain text configuration files and whitespace is important here.

Thanks, Barry.

[gmazzap]

Hi @barryo the trim was added to make comparing templates easier in unit tests, but I see more people using Foil as code builder, which was not what I had in mind, but fine :), so it makes sense.

Spaces are not a big issue in PHP so I can remove that trim without backward compatibility issue.

Don't really have time right know, happy to merge a PR to dev if you have time to send it.

[gmazzap]

Done with 1169c54, thanks @barryo

[barryo]

Hey @gmazzap - any plans to merge this into master / release?

We're shipping IXP Manager with a foil-dev requirement for a while now.

Thanks a million,
Barry

[gmazzap]

I will merge very soon.

[barryo]

Thanks for that @gmazzap !