This repository has been archived by the owner on Nov 26, 2020. It is now read-only.
Now the project is portable with storyboard. With no functionality (n… #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o scroll scrubber, no page indicator and bars) till there are constraints for the views
Read me update
…container is created from a stroyboard
|
The scroll scroll scrubber and page indicator are now adjusted if the view controller layout changed. |
| FolioReaderContainer.initSetup() | ||
|
|
||
| // Default values when the init called from storyboard | ||
| // TODO: Integrate contraints or storyboard to be more dynamic https://github.com/FolioReader/FolioReaderKit/issues/119 |
There was a problem hiding this comment.
Is this todo about this PR? I didn't get that...
There was a problem hiding this comment.
That's a good question. @PanajotisMaroungas can you answer it?
There was a problem hiding this comment.
No it's a future todo, I think it would be cleaner if we will use constraints instead of hardcoded values.
|
I can merge because of the conflict, can you fix that please, so I will be able to merge that. |
|
@hebertialmeida The conflicts are solved now :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…o scroll scrubber, no page indicator and bars) till there are constraints for the views