This repository has been archived by the owner on Nov 26, 2020. It is now read-only.
Create variable hidePageIndicator to hide page indicator. #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmersonCarpes
changed the title
hebertialmeida
suggested changes
Dec 22, 2016
| @@ -45,4 +45,4 @@ SPEC CHECKSUMS: | |||
|
|
|||
| PODFILE CHECKSUM: 591559c46a2b0a49e687795b8ae46fadbddf8fd4 | |||
|
|
|||
| COCOAPODS: 1.1.1 | |||
| COCOAPODS: 1.2.0.beta.1 | |||
There was a problem hiding this comment.
Let's not use the beta version for now, I think it is better to keep 1.1.1 which is the current stable.
| let pagesRemaining = FolioReader.needsRTLChange ? totalPages-(totalPages-page+1) : totalPages-page | ||
|
|
||
| pagesLabel.isHidden = hidePageIndicator |
There was a problem hiding this comment.
I don't think here is the best place to hide that, because you are inside the page indicator.
Probably the best option is not to alloc and add the page indicator as subview, you can easily do that on viewDidLoad of the FolioReaderCenter.swift on line 166, where the page indicator is created. Just check for hidePageIndicator there.
This way the PageIndicator background will also be hidden.
…scroll-direction"" This reverts commit db508bb.
|
I believe that's all right now, could you check please? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How can I disable PageIndicator #185