This repository has been archived by the owner on Nov 26, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 772
ePub 3.0 media overlays can be played and example updated to demonstrate #23
Merged
hebertialmeida
merged 33 commits into
FolioReader:master
from
kjantzer:feature/11-media-overlays
Jan 11, 2016
Merged
ePub 3.0 media overlays can be played and example updated to demonstrate #23
hebertialmeida
merged 33 commits into
FolioReader:master
from
kjantzer:feature/11-media-overlays
Jan 11, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in preparation of syncing narrated audio
Copy | Play | Highlight | Share
FolioReaderAudioPlayer needs adjusting to work with these nested elements. It currently expects a flat list of <par> elements
Found bug when media type is nil
Used to convert duration clock times in media overlay smil files
Grabs the first title
- Audio can be heard even if the lock/vibrate toggle is on - Added `isPlaying` method - Fixed the sync timer so that it works even when a webview is being scrolled
Once the user begins to scroll, synced audio will not auto-scroll until the user hasn't scrolled for 2 seconds.
- Both "share" and "audio" icons appear on right side of nav bar (when applicable) - Clicking "audio" icon opens a new "player controls" view which borrows its styling from the fonts menu view - Audio playback rate can be changed - Audio play icon and menu action only appear if the epub supports playback - Added a new config called `allowSharing`; if set to false, copying and sharing of the epub is disabled (may be desired when working with copyrighted content)
It was a segment view
Returns the `fullHref` without the file name
By default that is. It can be overridden by the user with the config New UIColor extensions added to support this.
Forgot in previous commit
ePub 3 audio syncing is in a stable and working order. It's been tested on multiple epub files. Improvements will be needed for more complex (nested) smil files.
This includes audio eBooks too
Ah, yes. My bad – those were some internal company epubs I was testing. I will remove the reference |
@hebertialmeida Try it now |
Thanks! |
hebertialmeida
added a commit
that referenced
this pull request
Jan 11, 2016
ePub 3.0 media overlays can be played and example updated to demonstrate
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11
Please test the functionality and let me know if changes are needed. I figure there will be more features added as we think of them, but this if a start at basic audio synced epubs