This repository has been archived by the owner on Nov 26, 2020. It is now read-only.
Swift 4, iPhone X support and Carthage fixes #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
paulocoutinhox
commented
Dec 7, 2017
paulocoutinhox
commented
- Swift 4 support
- Carthage fixes
added 19 commits
December 7, 2017 16:36
Source/FolioReaderCenter.swift
Outdated
| if let cell = collectionView.cellForItem(at: getCurrentIndexPath()) as? FolioReaderPage { | ||
| let cellSize = cell.frame.size | ||
|
|
||
| if let contentOffset = cell.webView?.scrollView.contentOffset { |
There was a problem hiding this comment.
You could use guard let here to reduce the chaining.
Source/FolioReaderCenter.swift
Outdated
| if let contentOffset = cell.webView?.scrollView.contentOffset { | ||
| let contentOffsetX = contentOffset.x + cellSize.width | ||
|
|
||
| if let contentOffsetXLimit = cell.webView?.scrollView.contentSize.width { |
There was a problem hiding this comment.
You could use guard let here to reduce the chaining.
Source/FolioReaderCenter.swift
Outdated
| public func changePageItemToPrevious(_ completion: (() -> Void)? = nil) { | ||
| // TODO: It was implemented for horizontal orientation. | ||
| // Need check page orientation (v/h) and make correct calc for vertical | ||
| if let cell = collectionView.cellForItem(at: getCurrentIndexPath()) as? FolioReaderPage { |
There was a problem hiding this comment.
You could use guard let here to reduce the chaining.
Source/FolioReaderCenter.swift
Outdated
| if let cell = collectionView.cellForItem(at: getCurrentIndexPath()) as? FolioReaderPage { | ||
| let cellSize = cell.frame.size | ||
|
|
||
| if let contentOffset = cell.webView?.scrollView.contentOffset { |
There was a problem hiding this comment.
You could use guard let here to reduce the chaining.
|
|
||
| - parameter recognizer: The tap recognizer | ||
| */ | ||
| @objc optional func pageTap(_ recognizer: UITapGestureRecognizer) |
hebertialmeida
changed the title
added 28 commits
December 21, 2017 16:58
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.