Changed dependencies to work with iOS 12.1 and Xcode 10.1 #377
Conversation
There was a problem hiding this comment.
Thanks @fantim the CI is failing and I believe that it is because FolioReaderKit/Example/Podfile.lock. Can you check that?
|
Hi @hebertialmeida , I have updated the Podlock.lock as well as updated the Cartfile.
though this may be due to an older version of xcode being used in the test (9.2). An update to xcode 9.3 or higher per tadija/AEXML#147 should fix this particular issue. |
|
Weird, my if you update the Xcode version https://github.com/FolioReader/FolioReaderKit/blob/master/.travis.yml#L1 |
|
Hi @hebertialmeida , I changed the tests to reflect the current version of iOS as well as fixed a bug I found when running simulator. Should pass CI now! |
|
Hi. I am having problem with xcode 10.x and ios 12.1. swift 4.2 |
|
Hi @hebertialmeida , previous version iteration of fixes would allow code to work on 12.1 on Xcode 10.1, but would was not converted to Swift 4.2 Newest commit converts to Swift 4.2, fixes some issues related to the conversion, passes Travis, and should work on a clean pod install under Examples folder. Tested running on Mojave 10.14.2 running Xcode 10.1. |
|
@hebertialmeida any plans to merge this and release new update? FolioReaderKit is bringing in lots of dependencies, since FolioReaderKit is not frequently updated, we are running into lots of problems. Please consider. |
|
Book Search Option is not available in iOS. Please suggest me when this feature is coming in iOS. |
maybe you can explain for the detail, because just now I try to install with pod install still have a problem. thanks bro |
@freakymaulana I will use the example project provided in this repository for reference. I also use pod deintegrate and pod clean for convenience. In a terminal, after navigating to the Example directory, run the following commands: pod deintegrate The last command may be redundant, but is there just to be sure that all the pods are the versions we desire. Hope this helps! |
|
I have just released the 1.4.0 to Cocoapods https://github.com/FolioReader/FolioReaderKit/releases/tag/1.4.0 |
|
Thanks @hebertialmeida ! Hoping others will benefit from this release! Cheers - |
|
@fantim thank you so much for your contributions, it will definitely help people using it! |
* 'master' of github.com:FolioReader/FolioReaderKit: (51 commits) Migrating documentation from cocoadocs to github pages Removing extra spaces Fix fast scroll bug (FolioReader#379) Migrated the Xcode project to use swift 4.2 Updated Cartfile to not use JSQWebViewController Bump minimum version support to iOS 9 and removed legacy JSQWebViewController Update FolioReaderKit.podspec Update README.md Update CHANGELOG.md Changed dependencies to work with iOS 12.1 and Xcode 10.1 (FolioReader#377) Fix crash on select segment at index. Swift 4.2 (FolioReader#361) Update issue templates method to get current progress between 0 and 100 (FolioReader#348) FolioReaderCenter.getCurrentChapterName() issue, applied recursive search for toc reference. (FolioReader#342) Fixed FolioReaderWebView, menu controller still showing colors menu after select any color in menu. (FolioReader#339) Fix iOS 11 auto adjust inset bug and closes #332 #312 #261 Update Cocoapods version Add Note function (FolioReader#335) Update LICENSE Fixed getCurrentChapter(), not returning some chapters, closes #302 thanks to @wesleycgs ...
Old dependencies causes issues with latest versions of iOS and Xcode. Updating dependencies should fix these issues without breaking functionality.