Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change filename separator to '_' from '-' so Sprockets works. #61

Merged
merged 2 commits into from
Apr 17, 2013

Conversation

unity
Copy link
Contributor

@unity unity commented Apr 14, 2013

When using Sprockets, the current filename format causes Not Found errors.
Switching to '_' as a separator fixes this.

@kaizau
Copy link
Member

kaizau commented Apr 14, 2013

That's curious. Is there a reason Sprockets doesn't support dashes, or is it a bug?

@unity
Copy link
Contributor Author

unity commented Apr 14, 2013

I guess it has something to do with them adding digest themselves when precompiling.

Didn't find anything in their docs, so must be a bug.

Since it's trivial to fix (and much faster), and has very limited impact from fontcustom I thought it was better that way

@unity
Copy link
Contributor Author

unity commented Apr 14, 2013

After digging a little :

rails/rails#9788

Romain Dardour, Hull
romain@hull.io

On 14 avr. 2013, at 16:38, Romain Dardour romain@hull.io wrote:

I guess it has something to do with them adding digest themselves when precompiling.

Didn't find anything in their docs, so must be a bug.

Since it's trivial to fix (and much faster), and has very limited impact from fontcustom I thought it was better that way

@kaizau
Copy link
Member

kaizau commented Apr 14, 2013

Ah, that looks like the culprit. Agreed that it's a harmless workaround.

Some of the tests regex's may fail with this change. Can you update those first?

@unity
Copy link
Contributor Author

unity commented Apr 15, 2013

Updated tests

kaizau pushed a commit that referenced this pull request Apr 17, 2013
change filename separator to '_' from '-' so Sprockets works.
@kaizau kaizau merged commit fb6bf79 into FontCustom:big-refactor Apr 17, 2013
@kaizau
Copy link
Member

kaizau commented Apr 17, 2013

Thanks for the catch!

@unity unity deleted the fix_sprockets_compatibility branch February 1, 2015 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants