Nice work, the GTK-4 update looks great

[alerque]

I just packaged v0.9.0 for Arch Linux and had a look. I've seen the GTK-4 dev activity for a while but never checked it out. I just gave it a spin and was pleasantly surprised. A few rough edges maybe, a few bits that seem counter intuitive to me, but overall a nice experience. Thanks for all the work.

---

_{Also it's probably time to close #55 and move on.}

[JerryCasiano]

Thanks for the feedback.

I had to look to see what 55 was.... 😂

But honestly more interested in the areas you think could be improved or what you find counter intuitive, since it's likely other people will feel the same.

If it's stuff that can easily be sorted, we probably should.

[alerque]

I'm kinda buried in another project that doesn't involve scouring my fonts right now. I'll try to make full reports on these later:

• The preview pane doesn't gracefully handle window size changes and sometimes gets stuck "open" but slammed over at 1 pixel wide on the right after window size events. I'm on Wayland with a tiling window manager (Hyprland) which probably affects what signals it is getting.
• The font name browser interface is a bit glitchy and regularly reverts to some previous scroll position loosing what I was looking at. For example "scroll down a bit", "click on a font name", "touch the menu over in the waterfall", "close the menu" → the browse scroll position jumps somewhere. Not every time so this isn't a proper bug report, but something is amiss.
• Some of the preferences for the waterfall could probably move to a menu from the waterfall pane, not only in preferences.
• The font name browser has a zoom, but it only even affects the height of the preview buttons, not the width. For me there is some maximum of 7 columns no matter how wide a display I put it on (I have a few pixels available).
• The zoom in the font name browser doesn't stick. I would expect it to be maintained across sessions, e.g. as a preference.
• It isn't apparent to me what the "active" toggle switch under the waterfall preview even is or does.

More (and full bug reports if necessary) when I have the chance. Again my first impression having not used it in a while was quite positive.

[PF4Public]

• The icon near the triangle is broken even if adwaita is enabled
• Expand-collapse triangles do not work consistently:
  

[JerryCasiano]

@PF4Public

Please see if the increased margin in the latest commit helps.

Not sure what else we can really do there, it's just a standard Gtk.TreeExpander.

It seems the best place to click them is at the front point or right in the middle, otherwise it's inconsistent whether they get the event or not, I noticed that a while back.

ETA -

The missing icon in your image is "list-drag-handle-symbolic". It's definitely included in the Adwaita icon theme. We may have to ship it so that we don't depend on that theme, I guess I just assumed it was common for themes to include that icon.

[PF4Public]

Just built from 6208162. It got better. Tried clicking many times and it seems that the next pixel on the left from the triangle is used for resize, although cursor does not change. Perhaps it is what interferes here?

The missing icon in your image is "list-drag-handle-symbolic". It's definitely included in the Adwaita icon theme. We may have to ship it so that we don't depend on that theme, I guess I just assumed it was common for themes to include that icon.

Indeed! Just checked, I have another icon theme selected. Should I select Adwaita, the icon appears. It is up to you, whether you'd like to fix it. Have you considered Adwaita license, would it be OK to redistibute it?

[JerryCasiano]

Perhaps it is what interferes here?

Doesn't appear to be unfortunately, I tried setting a huge margin (24 px) on it and it didn't make much difference at all from the current 6px margin.

Have you considered Adwaita license, would it be OK to redistibute it?

I have not, I would assume the license allows it. But doesn't matter if it doesn't we can source similar icons from somewhere else.

I think what we'll do is ship a set of fallback icons that includes just the ones we use, that seems like the best option if I can get it to work right. Might need your feedback on that front.

[PF4Public]

I tried setting a huge margin (24 px) on it and it didn't make much difference at all from the current 6px margin.

Could it be the margin from the thing that resizes the pane further left from triangles?

Might need your feedback on that front.

Sure thing!

[JerryCasiano]

Could it be the margin from the thing that resizes the pane further left from triangles?

Ha! I considered that too! I think you're right it probably is the "handle" for the pane itself that's causing the inconsistency.

But unfortunately I'm not sure we can do anything there without creating another issue, now you can't resize the pane consistently...

I'll play around with it and see if it's something we're doing wrong or maybe there's a workaround. I might just file a bug against GTK though. Devs really shouldn't have to fuss with padding and margins for a standard widget to work right when placed next to another standard widget.

[JerryCasiano]

@PF4Public

There's a branch at https://github.com/FontManager/font-manager/tree/fallback-icons which ships icons we use in the interface and installs them in a fallback directory.

When you have some time, if you could build from that branch and see if it actually works as intended that would be great. If it does, I can merge into master.

[PF4Public]

see if it actually works as intended

Well, yes and no :) There is a white border for whatever reason and icons are barely visible on a dark theme:

[JerryCasiano]

@PF4Public

The border is an easy fix.

But I have no idea why GTK isn't recoloring those icons properly. They are not even correctly colored with the light theme and only some of them are actually loaded.

I was never able to get icons loaded from a resource to work correctly either...

[PF4Public]

That's unfortunate. Could we get rid of misbehaving icons then? :D

[JerryCasiano]

@PF4Public

I think I got the icons sorted in master. Give it a shot when you have moment and let me know.

Thanks again.