Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix demo page #659

Merged
merged 1 commit into from
Oct 26, 2024
Merged

Fix demo page #659

merged 1 commit into from
Oct 26, 2024

Conversation

DrRataplan
Copy link
Collaborator

Use vite instead of old snowpack. Works a lot easier, just requires some type imports in index.ts.
@bwrrp , you're on windows now right? Can you give this a quick run?

@DrRataplan DrRataplan requested a review from bwrrp October 22, 2024 07:42
Use vite instead of old snowpack. Works a lot easier, just requires some `type` imports in index.ts
Copy link

bundlemon bot commented Oct 22, 2024

BundleMon

Unchanged files (2)
Status Path Size Limits
fontoxpath.esm.js
78.54KB -
fontoxpath.js
78.43KB -

No change in files bundle size

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@coveralls
Copy link

Coverage Status

coverage: 91.567%. remained the same
when pulling 3f7c4ab on demo
into 67b87f8 on master.

Copy link
Member

@bwrrp bwrrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No config needed? Nice!

Works perfectly on WSL, but I had to delete package-lock.json on Windows to work around a bug in npm where it didn't install @rollup/rollup-win32-x64-msvc ☹️
That was clearly explained in the error though, so approving anyway.

@DrRataplan
Copy link
Collaborator Author

Awesome! That sounds scary. But happy to hear it works!

@DrRataplan DrRataplan merged commit 0618992 into master Oct 26, 2024
17 checks passed
@DrRataplan DrRataplan deleted the demo branch October 26, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants