Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed issues 1, 3, 5 #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed issues 1, 3, 5 #8

wants to merge 1 commit into from

Conversation

chensteven
Copy link
Contributor

@chensteven chensteven commented Nov 7, 2018 •
edited
Loading

Please confirm issue #1, #3, #5 is fixed. If so, merge pull request and I will close the Issues.

@chensteven chensteven mentioned this pull request Nov 7, 2018
Open
@chensteven chensteven changed the title fixed issue 3 and 5 fixed issues 1, 3, 5 Nov 7, 2018
This was referenced Nov 7, 2018
Open
Open
vincenthang
vincenthang requested changes Nov 8, 2018
View reviewed changes
Copy link

@vincenthang vincenthang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of issues introduced:

  1. the Confirm button on the SMS authentication screen doesn't work for me. (given ERROR: Attempt Limit Exceeded in console; and cannot exit out of the authentication screen)

  2. if you exit the app on the SMS authentication screen, the phone number becomes taken. (should be still available)

And an enhancement:

  • we should keep the email just for reference (no verification), it's good for early-stage growth with email marketing.

TLDR: #1, and #3 solved; but issues above were introduced (I couldn't sign up).

@chensteven
Copy link
Contributor Author

  1. I can't repeat this. Can you provide the steps to repeat this or give more info?
  2. That's reasonable since you signed up but just haven't confirmed yet. What should happen is the UI flow for Resend Confirmation Code.

Enhancement:
Ok, an input form can be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincenthang vincenthang vincenthang requested changes

Assignees

@vincenthang vincenthang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chensteven @vincenthang