Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for \cancel and co. #402

Merged
merged 7 commits into from
May 24, 2023
Merged

Add support for \cancel and co. #402

merged 7 commits into from
May 24, 2023

Conversation

Orace
Copy link
Contributor

@Orace Orace commented May 22, 2023

This commit address #349 and add support to:

  • \cancel
  • \bcancel
  • \xcancel
  • \cancelto

Current output of \cancel{Q} \\ \xcancel{69} \\ \frac{a\bcancel{b}}{\bcancel{b}}:

cancel

Copy link
Owner

@ForNeVeR ForNeVeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! There's a couple of minor issues left, could you please take a look?

I should note that this is a breaking change technically, but a good one and for a good reason, so I approve that.

src/XamlMath.Shared/Boxes/ZBox.cs Outdated Show resolved Hide resolved
src/XamlMath.Shared/Boxes/ZBox.cs Outdated Show resolved Hide resolved
@Orace
Copy link
Contributor Author

Orace commented May 23, 2023

@ForNeVeR, this is a draft work, I'm open to (and ask for) any advice on this.

@ForNeVeR ForNeVeR self-assigned this May 23, 2023
@ForNeVeR ForNeVeR self-requested a review May 23, 2023 19:00
@Orace
Copy link
Contributor Author

Orace commented May 24, 2023

\cancelto need an arrow, I don't know how to draw this, maybe something like what is done for the radical atom (sqrt, √), maybe we should work on this in another PR (I will be AFK for several weeks soon).

Copy link
Owner

@ForNeVeR ForNeVeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ForNeVeR
Copy link
Owner

I think we'll leave \cancelto still open for grabs for now.

ForNeVeR added a commit to Orace/xaml-math that referenced this pull request May 24, 2023
ForNeVeR added a commit to Orace/xaml-math that referenced this pull request May 24, 2023
ForNeVeR added a commit to Orace/xaml-math that referenced this pull request May 24, 2023
@ForNeVeR ForNeVeR merged commit ab2f38e into ForNeVeR:master May 24, 2023
@Orace Orace deleted the AddCancel branch May 24, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants