Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possibly leaked handle? #129

Closed
acepace opened this issue Apr 9, 2020 · 2 comments
Closed

Possibly leaked handle? #129

acepace opened this issue Apr 9, 2020 · 2 comments

Comments

@acepace
Copy link

acepace commented Apr 9, 2020

Running tests using sync-request and Jest has Jest detecting a possibly leaked handle.

PROCESSWRAP

      at start (node_modules/sync-rpc/lib/index.js:33:13)
      at sendMessage (node_modules/sync-rpc/lib/index.js:133:17)
      at createClient (node_modules/sync-rpc/lib/index.js:173:27)
      at Object.<anonymous> (node_modules/sync-request/lib/index.js:16:14)
@prateeksha23
Copy link

I am also facing the same issue. Is there any update?

@nktnet1
Copy link

nktnet1 commented Oct 8, 2023 •
edited
Loading

Had a similar problem with Jest so I wrote a library called sync-request-curl.

The usage is the same.

sync-request-curl is free from this bug and has better performances from leveraging node-libcurl, but doesn't have close to the same level of compatibility as sync-request. It only works with recent versions of NodeJS and has no support for JavaScript in the Browser.

I believe this issue is also closely linked with #137.

The cause is sync-rpc and is explained in issue 10:

Drarig29 added a commit to DataDog/datadog-ci-azure-devops that referenced this issue Nov 14, 2023
@Drarig29
Bump azure-pipelines-task-lib to fix open handles
07464dd 
- microsoft/azure-pipelines-task-lib#932
- ForbesLindesay/sync-request#129
@Drarig29 Drarig29 mentioned this issue Nov 14, 2023
Merged
Drarig29 added a commit to DataDog/datadog-ci-azure-devops that referenced this issue Nov 15, 2023
@Drarig29
[test] Fix open handles in unit tests (#117)
f53c760 
* Bump azure-pipelines-task-lib to fix open handles

- microsoft/azure-pipelines-task-lib#932
- ForbesLindesay/sync-request#129

* Fix "Could not locate the bindings file"

* Run mock tasks asynchronously
Drarig29 added a commit to DataDog/datadog-ci-azure-devops that referenced this issue Nov 15, 2023
@Drarig29
[dep] Remove superfluous libraries (#118)
28caa51 
* Bump azure-pipelines-task-lib to fix open handles

- microsoft/azure-pipelines-task-lib#932
- ForbesLindesay/sync-request#129

* Fix "Could not locate the bindings file"

* Run mock tasks asynchronously

* [dep] Remove superfluous libraries

* Try node 10 entrypoint

* Revert "Try node 10 entrypoint"

This reverts commit b962ed3.
Drarig29 added a commit to DataDog/datadog-ci-azure-devops that referenced this issue Nov 15, 2023
@Drarig29
[test] Download Node.js 16 only (#119)
1207548 
* Bump azure-pipelines-task-lib to fix open handles

- microsoft/azure-pipelines-task-lib#932
- ForbesLindesay/sync-request#129

* Fix "Could not locate the bindings file"

* Run mock tasks asynchronously

* [test] Download Node.js only once
@acepace acepace closed this as completed Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@acepace @prateeksha23 @nktnet1