-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V0.12 #53
V0.12 #53
Conversation
Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Everything looks good, I didn't know about the path issue for embedded assets, that's a good catch.
I added a few nitpick but otherwise LGTM
let bind_group = device.create_bind_group( | ||
Some("polyline_material_bind_group"), | ||
&polyline_pipeline.material_layout, | ||
&[BindGroupEntry { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need to change it in this PR, but you can use BindGroupEntries::single()
here.
Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors |
|
81172b3
into
ForesightMiningSoftwareCorporation:main
upgrade to bevy 0.12. Use
embedded_asset
.The current path seems to have some problems on different platforms and needs to be dealt with individually.