Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bevy 0.13 #64

Merged
merged 9 commits into from
Apr 6, 2024
Merged

Conversation

Lethja
Copy link
Contributor

@Lethja Lethja commented Mar 10, 2024

Updated code to build for Bevy 0.13

PR Status

@Lethja
Copy link
Contributor Author

Lethja commented Mar 10, 2024

Example scenes will panic when clicking any select-able object in the scene with the following message on commit 8c31bea:

thread 'main' panicked at ~/.cargo/registry/src/index.crates.io-6f17d22bba15001f/wgpu-0.19.3/src/backend/wgpu_core.rs:3006:5:
wgpu error: Validation Error

Caused by:
    In Device::create_render_pipeline
      note: label = `opaque_mesh_pipeline`
    Error matching ShaderStages(FRAGMENT) shader requirements against the pipeline
    Shader global ResourceBinding { group: 1, binding: 0 } is not available in the pipeline layout
    Storage class Storage { access: StorageAccess(LOAD) } doesn't match the shader Uniform

@Lethja
Copy link
Contributor Author

Lethja commented Mar 10, 2024

Example scenes will panic when clicking any select-able object in the scene with the following message on commit 8c31bea:

Issue will be resolved by Bevy 0.13.1 see bevyengine/bevy#12032

@Lethja Lethja marked this pull request as ready for review March 10, 2024 22:41
@Lethja
Copy link
Contributor Author

Lethja commented Mar 19, 2024

Bevy 0.13.1 has been released but the wgpu panic remains

@zachbateman
Copy link
Contributor

Hey @Lethja, the PR I just submitted (#65) should take care of that wgpu panic.

src/mesh/mod.rs Outdated Show resolved Hide resolved
@Lethja
Copy link
Contributor Author

Lethja commented Apr 4, 2024

Ready for another CI attempt at 0aa13f8

@aevyrie
Copy link
Collaborator

aevyrie commented Apr 6, 2024

Looks great, thank you!

@aevyrie aevyrie merged commit 16c5698 into ForesightMiningSoftwareCorporation:main Apr 6, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants