Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.0][MIG] rma_repair #55

Merged
merged 3 commits into from
Nov 26, 2018
Merged

[11.0][MIG] rma_repair #55

merged 3 commits into from
Nov 26, 2018

Conversation

AdriaGForgeFlow
Copy link
Contributor

Migration of rma_repair module to v11.0

@coveralls
Copy link

coveralls commented Nov 21, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.6%) to 71.292% when pulling 5ca7c8d on 11.0-mig-rma_repair into 6e1eb06 on 11.0.

@codecov-io
Copy link

codecov-io commented Nov 21, 2018 •
edited
Loading

Codecov Report

Merging #55 into 11.0 will increase coverage by 0.59%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             11.0      #55      +/-   ##
==========================================
+ Coverage   70.69%   71.29%   +0.59%     
==========================================
  Files          36       41       +5     
  Lines        1959     2090     +131     
==========================================
+ Hits         1385     1490     +105     
- Misses        574      600      +26
Impacted Files Coverage Δ
rma_repair/models/mrp_repair.py 100% <100%> (ø)
rma_repair/models/rma_order.py 42.85% <100%> (ø)
rma_repair/models/rma_order_line.py 75% <100%> (ø)
rma_repair/models/rma_operation.py 100% <100%> (ø)
rma_repair/wizards/rma_order_line_make_repair.py 89.06% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e1eb06...5ca7c8d. Read the comment docs.

LoisRForgeFlow
LoisRForgeFlow requested changes Nov 21, 2018
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Some comments inline.

rma_repair/models/rma_order_line.py Outdated Show resolved Hide resolved
rma_repair/tests/test_rma_repair.py Outdated Show resolved Hide resolved
rma_repair/tests/test_rma_repair.py Outdated Show resolved Hide resolved
rma_repair/README.rst Outdated Show resolved Hide resolved
@LoisRForgeFlow
Copy link
Contributor

Code and tests looks good. functionally I found two extra issues:

  1. Could you try to remove the save and discard buttons from the wizard? The other wizards from the rma.order.line doesn't have those buttons.
    image

  2. When I set thec checkbox "to refurbish" I get this error. Could you check that too?
    image

LoisRForgeFlow
LoisRForgeFlow approved these changes Nov 26, 2018
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely now! 👍

@LoisRForgeFlow LoisRForgeFlow merged commit e1cc3be into 11.0 Nov 26, 2018
@LoisRForgeFlow LoisRForgeFlow deleted the 11.0-mig-rma_repair branch November 26, 2018 08:09
grindtildeath pushed a commit to grindtildeath/stock-rma that referenced this pull request Mar 12, 2019
@AdriaGForgeFlow @grindtildeath
[11.0][MIG] rma_repair (ForgeFlow#55)
3a4b25d
bodedra pushed a commit to ursais/stock-rma that referenced this pull request Apr 11, 2019
@AdriaGForgeFlow
[11.0][MIG] rma_repair (ForgeFlow#55)
a83355a
AaronHForgeFlow pushed a commit that referenced this pull request Mar 19, 2020
@AdriaGForgeFlow @AaronHForgeFlow
[11.0][MIG] rma_repair (#55)
1bdcdd6
MateuGForgeFlow pushed a commit that referenced this pull request Dec 21, 2020
@AdriaGForgeFlow @MateuGForgeFlow
[11.0][MIG] rma_repair (#55)
b707917
MateuGForgeFlow pushed a commit that referenced this pull request Jan 19, 2021
@AdriaGForgeFlow @MateuGForgeFlow
[11.0][MIG] rma_repair (#55)
36b6063
MateuGForgeFlow pushed a commit that referenced this pull request Jan 27, 2021
@AdriaGForgeFlow @MateuGForgeFlow
[11.0][MIG] rma_repair (#55)
2300d5c
MateuGForgeFlow pushed a commit that referenced this pull request Jan 28, 2021
@AdriaGForgeFlow @MateuGForgeFlow
[11.0][MIG] rma_repair (#55)
1694b0f
MateuGForgeFlow pushed a commit that referenced this pull request Feb 1, 2021
@AdriaGForgeFlow @MateuGForgeFlow
[11.0][MIG] rma_repair (#55)
6a474ed
MateuGForgeFlow pushed a commit that referenced this pull request Feb 11, 2021
@AdriaGForgeFlow @MateuGForgeFlow
[11.0][MIG] rma_repair (#55)
7f129d5
JasminSForgeFlow pushed a commit that referenced this pull request Jan 10, 2022
@AdriaGForgeFlow @JasminSForgeFlow
[11.0][MIG] rma_repair (#55)
0e1cb23
LoisRForgeFlow pushed a commit that referenced this pull request Feb 10, 2022
@AdriaGForgeFlow @LoisRForgeFlow
[11.0][MIG] rma_repair (#55)
deb2792
DavidJForgeFlow pushed a commit that referenced this pull request Feb 24, 2023
@AdriaGForgeFlow @DavidJForgeFlow
[11.0][MIG] rma_repair (#55)
845236f
JordiBForgeFlow pushed a commit that referenced this pull request Jul 7, 2023
@AdriaGForgeFlow @JordiBForgeFlow
[11.0][MIG] rma_repair (#55)
9e15ab6
JordiBForgeFlow pushed a commit that referenced this pull request Jul 7, 2023
@AdriaGForgeFlow @JordiBForgeFlow
[11.0][MIG] rma_repair (#55)
d5170b7
cgsurf pushed a commit to ursais/stock-rma that referenced this pull request Aug 5, 2024
@AdriaGForgeFlow @anoomk
[11.0][MIG] rma_repair (ForgeFlow#55)
3e2c223
JasminSForgeFlow pushed a commit that referenced this pull request Jan 8, 2025
@AdriaGForgeFlow @JasminSForgeFlow
[11.0][MIG] rma_repair (#55)
d87a5d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AdriaGForgeFlow @coveralls @codecov-io @LoisRForgeFlow