-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new Connector types #22
Conversation
…, LABEL, PASSWORD and PASSWORD_VERIFY)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 👍🏻
XCTAssertEqual("test", fieldCollector.value) | ||
} | ||
// func testShouldReturnValueWhenValueIsSet() { | ||
// let fieldCollector = MockFieldCollector() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's intentional, lets add a description why it's commented out or remove it. Also, update header
// CustomViews.swift | ||
// PingExample | ||
// | ||
// Copyright (c) 2024 - 2025 Ping Identity. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copyright (c) 2025
// AccessTokenViewModel.swift | ||
// PingExample | ||
// | ||
// Copyright (c) 2024 - 2025 Ping Identity. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copyright (c) 2025
// AccessTokenView.swift | ||
// PingExample | ||
// | ||
// Copyright (c) 2024 - 2025 Ping Identity. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copyright (c) 2025
// DavinciView.swift | ||
// PingExample | ||
// | ||
// Copyright (c) 2024 - 2025 Ping Identity. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copyright (c) 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copyright (c) 2024 - 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good to me. Minor comments to address
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SDKS-3671 [iOS] Add Support for Field Type (LABEL, CHECKBOX, DROPDOWN, COMBOBOX, RADIO, FLOWLINK) in the SDK
SDKS-3672 [iOS] Add Support for Field Type (PASSWORD, PASSWORD_VERIFY) in the SDK
Implemented
Pending