Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Connector types #22

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Add new Connector types #22

merged 3 commits into from
Jan 21, 2025

Conversation

vahancouver
Copy link
Contributor

SDKS-3671 [iOS] Add Support for Field Type (LABEL, CHECKBOX, DROPDOWN, COMBOBOX, RADIO, FLOWLINK) in the SDK

SDKS-3672 [iOS] Add Support for Field Type (PASSWORD, PASSWORD_VERIFY) in the SDK

Implemented

  • Add support for the following field types: DROPDOWN CHECKBOX RADIO FLOWLINK COMBOBOX LABEL PASSWORD PASSWORD_VERIFY
  • Implement required field validation for applicable types.
  • Allow fields to handle single and multi-value inputs based on the type.
  • Update the SDK testing app to showcase the new field types, and validations.
  • Support Password Policy Validation where applicable.

Pending

  • Write comprehensive unit tests

Copy link
Contributor

@spetrov spetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍🏻

XCTAssertEqual("test", fieldCollector.value)
}
// func testShouldReturnValueWhenValueIsSet() {
// let fieldCollector = MockFieldCollector()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's intentional, lets add a description why it's commented out or remove it. Also, update header

// CustomViews.swift
// PingExample
//
// Copyright (c) 2024 - 2025 Ping Identity. All rights reserved.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright (c) 2025

// AccessTokenViewModel.swift
// PingExample
//
// Copyright (c) 2024 - 2025 Ping Identity. All rights reserved.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright (c) 2025

// AccessTokenView.swift
// PingExample
//
// Copyright (c) 2024 - 2025 Ping Identity. All rights reserved.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright (c) 2025

// DavinciView.swift
// PingExample
//
// Copyright (c) 2024 - 2025 Ping Identity. All rights reserved.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright (c) 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright (c) 2024 - 2025

Copy link

@rodrigoareis rodrigoareis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me. Minor comments to address

Copy link

@rodrigoareis rodrigoareis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@spetrov spetrov merged commit 671adfe into develop Jan 21, 2025
9 checks passed
@spetrov spetrov deleted the SDKS-3671-add-new-field-types branch January 21, 2025 21:57
@spetrov spetrov restored the SDKS-3671-add-new-field-types branch January 21, 2025 22:27
@spetrov spetrov deleted the SDKS-3671-add-new-field-types branch January 21, 2025 22:30
Copy link

@witrisna witrisna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants