Changes count not reseting

[aonez]

Reported via Twitter.

The counter increments correctly, but It does not drop when a commit is done. Can't see any log relating to this issue.

• On a machine I got this issue and after updating and rolling back it's no more present.
• On my primary machine I've created a test repository and now I have no counter at all:

Reproduced in OS X 10.11.6 and macOS 10.13. From 1.0.57.6 to 1.0.58.2.

[DanPristupov]

A lot of people have reported this issue, but I still can't reproduce it. I'll continue investigating the problem.

Please share if you find more details.

[clounie]

I don't have a hard repro at this point, but from my experience it generally happens when I'm using the git CLI + Fork at the same time.

[aonez]

@clounie I only work with git CLI when Fork fails on a rebase or something involving too much changes. Usually I only use Fork, and the count fails to reset.

[bwl21]

I did a git gc on the command line, maybe this might help. Anyhow the changes counter is not really reliable. I even would prefer if the uncommitted changes would be visible the commit history (see my comment on #107)

[DanPristupov]

I'm finally back from the holidays and investigating this bug now.

@bwl21 I recently added additional logging related to this problem. You can really help me to fix it if you send me the log file which is located at ~/Library/Caches/Fork/fork.log to support@git-fork.com. Thank you in advance.

[bwl21]

As a pity, the issue is still there in 1.0.65.1

[aonez]

send me the log file which is located at ~/Library/Caches/Fork/fork.log to support@git-fork.com.

You still need those? I can send you mine too.

I'm now somewhat used to don't care about the count number, since it is not reliable. But Fork still rocks hard, little issue really.

[aonez]

Working again for me in the last hot-fix update 1.0.69.4 😎

[DanPristupov]

Can we close that now (in 1.0.72)?

[aonez]

I can't even reproduce this with 1.0.71.2. So for my part you can close this. Hopping to see the day when we can support this project 💰

[bwl21]

as a pity I still have the issue in 1.0.72.1. In the following screenshot you see, there is a chage, but
in the "changes"

[aonez]

@bwl21 what OS do you use? Also, the repository is local/remote and on what hosting if the later?

[aonez]

By the way the buttons on your screenshot look funny.

Do you use the old toolbar style or it is imposed for using an old OS?

[bwl21]

I am on el capitan. repository is hosted github. But not all branches are pushed there.

[aonez]

Thanks @bwl21! @DanPristupov I was also working on an old Mac Mini with Mac OS X 10.11 El Capitan when reported this one. Now I can't reproduce but my minimum OS is 10.13. Will try to reproduce on a VM. Nah, forget it:

Reproduced in OS X 10.11.6 and macOS 10.13. From 1.0.57.6 to 1.0.58.2.

Forgot this line of the first report. So the OS should no be the reason.

[bwl21]

Do you use the old toolbar style or it is imposed for using an old OS?

i did not change the toolbar setting up to now, so it is the old style

[bwl21]

Forgot this line of the first report. So the OS should no be the reason.

I tried with https://github.com/bwl21/react-jspdf-example, a very small repository. It still happens that the Counter is not updated.

[DanPristupov]

@aonez, @bwl21
Can I create for you a special Fork build with additional logging which will help to find the bug?

[bwl21]

sure. can it be installed in parallel?

[aonez]

If I can reproduce this again (not the case now) I'll for sure use the build with additional logging.

[DanPristupov]

OK, I'm investigating this problem right now.

sure. can it be installed in parallel?

Yes, it won't require installation, you can run it right from the DMG file.

@aonez @aonez thank you! Please contact me by email (support@forkapp.io) so I could send you the build.