Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Octolapse causes SimpleEmergencyStop to misbehave in FireFox 78.0.2 on OctoPrint 1.4.1rc2 #567

Open
b-morgan opened this issue Jul 9, 2020 · 4 comments
Open

Octolapse causes SimpleEmergencyStop to misbehave in FireFox 78.0.2 on OctoPrint 1.4.1rc2 #567

b-morgan opened this issue Jul 9, 2020 · 4 comments

Comments

@b-morgan
Copy link

b-morgan commented Jul 9, 2020

See https://github.com/Sebclem/OctoPrint-SimpleEmergencyStop/issues/14#. I am opening this issue because disabling Octolapse fixes SimpleEmergencyStop.

This problem did (does not) occur with OctoPrint 1.4.0.

Version of Octolapse

Octolapse Version: 0.4.0

Version of OctoPrint

OctoPrint Version: 1.4.1rc2

When you ran into the problem, did you have diagnostic logging enabled?

Diagnostic Logging was Enabled: No

What were you doing when the problem occurred

  1. Install SimpleEmergencyStop plugin
  2. Install Octolapse plugin
  3. Open OctoPrint in FireFox

What should have happened?

NavBar should display like it does in Chrome

What happened instead?

NavBar contains both versions of SimpleEmergencyStop buttons. Neither one is functional. Octolapse NavBar button is missing.

Operating System running OctoPrint and Octolapse

OS Name: OctoPi
Os Version: 0.17.0

Browser and version of browser, operating system running browser

Browser: FireFox 78.0.2
Browser OS: Windows 10 (64-bit)
@FormerLurker
Copy link
Owner

@b-morgan, I will see what I can find. I wonder if other navbar buttons work with SimpleEmergencyStop.

@b-morgan
Copy link
Author

b-morgan commented Jul 9, 2020

The answer to that question may be "No". Below are screenshots of the NavBar from FireFox and Chrome. As you can see, I've got two other NavBar plugins that disappear in FireFox. List of my plugins is also included.

FireFox:
587-FireFox
Chrome:
587-Chrome

plugins.txt

@FormerLurker
Copy link
Owner

OK, it's looking like a shared CSS issue, which might be OctoPrint related. If I find this is the case I'll post either an issue or a pull request on the OctoPrint github page.

@b-morgan b-morgan mentioned this issue Jul 10, 2020
Closed
3 tasks
foosel added a commit to OctoPrint/OctoPrint that referenced this issue Jul 10, 2020
@foosel
🥅 Disable minification again by default
7915e6c 
It might cause SyntaxErrors in third party plugins that cannot be
caught by the system and which then nuke ALL other third party plugins.

See Sebclem/OctoPrint-SimpleEmergencyStop#14 and
FormerLurker/Octolapse#567

This change can manually be applied by setting

``` yaml
devel:
  webassets:
    minify: false
```

in config.yaml
@foosel foosel mentioned this issue Jul 10, 2020
Closed
@foosel
Copy link

foosel commented Jul 13, 2020

Just for the record, that is an issue with SimpleEmergencyStop (it causes a JS SyntaxError when minified, nuking all of bundled_plugins.js), not Octolapse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@foosel @b-morgan @FormerLurker