Widget Locking #78
Merged
Widget Locking #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etion based on editing state
…emove action from default Type component
… update changelog state directly. add updateOtherStates for setting all other logs to editing=false when clicking edit on a changelog
…lements were not pulling in the temp version of the data
…closes the editing state for any other widget
…), add date-fns library for date validation
…guage used elsewhere in the widget
|
another great companion feature to the manual editing. Looks nice, feels nice, simple, works like a charm. Only one tweak and one question. Instead of the padlock icon in prop menu can we use text to be consistent. Lock should be fine? When locked, should we consider hiding the + action similar to other UI? My concern is around changing the context of the icon. |
ryansrofe
requested changes
Apr 12, 2024
ryansrofe
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the ability to lock the widget to the properties menu. Locking causes everything that is normally editable by click to be display only and transforms the add button into a lock icon to indicate the widgets locked status outside of the property menu - lock icon does not have a click action.
Fixes #48, dependent on #77
Type of Change
How Has This Been Tested?
Verified that all editable elements are unaccessible while widget is locked, and return to being editable once widget is unlocked.