Move react-json-view to peer dependency #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid infinite loop in npm installs due to conflicting React peer deps in client projects ref: npm/cli#6611
🦋 Changeset detectedLatest commit: 60ee801 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
carbonrobot
changed the title
colinrobertbrooks
approved these changes
Nov 9, 2023
yankovalera
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
@microlink/react-json-viewto peer dependency. Reported by @yankovaleraBug
Installing with
npm>7.xcauses an infinite loop due to conflicting React peer deps in client projectsref: npm/cli#6611
Background
npm > 7 now installs peer dependencies by default
When running
npm i @envyjs/webuiin an demo repo,npmwill automatically install peer dependencies and fail with an infinite loop. This is because@microlink/react-json-viewhas a dependency onflux, andfluxhas a peer dependency on React@17, whileenvyhas a peer dependency on React@18. The current npm bug then prevents the install and crashes.Locally, within the envy repo everything works as expected because we have a peer dependency resolution in our main
package.jsonfile.Change
This moves
@microlink/react-json-viewto a peer dependency which has the following effectnpm>7and used in the default way,@envyjs/webuiwill work as expectednpm>7and used as a custom viewer component,@envyjs/webuiwill work as expectedyarn/pnpmand used in the default way,@envyjs/webuiwill work as expectedyarn/pnpmand used as a custom viewer component, users will also need to install@microlink/react-json-viewas a dependency, sinceyarn/pnpmdo not install peer deps automaticallyFuture
Many dependencies under
@microlink/react-json-vieware either deprecated or outdated. We should look into alternatives for json display. One possible replacement is the component we use in thegroqd's arcade...monaco-editor