Code

BUG: hidden app roots (v2)#107

Code

Merged

ryan-roemer merged 59 commits intomasterFormidableLabs/inspectpack:masterfrom bug/hidden-app-roots-v2FormidableLabs/inspectpack:bug/hidden-app-roots-v2Copy head branch name to clipboardMar 26, 2019

+1,106-157

Commits

Commits on Feb 26, 2019

• Add regression test fixture. Still need regression test.

  ryan-roemer

  committed
  1d01023

  Copy full SHA for 1d01023

• Add regression tests

  ryan-roemer

  committed
  12a6b6b

  Copy full SHA for 12a6b6b

• Remove unneeded alias

  ryan-roemer

  committed
  4146d0b

  Copy full SHA for 4146d0b

• Remove unneeded resolve too

  ryan-roemer

  committed
  b702591

  Copy full SHA for b702591

• Fix lint

  ryan-roemer

  committed
  b31f0ea

  Copy full SHA for b31f0ea

Commits on Feb 27, 2019

• Fix fixture pkg.main

  ryan-roemer

  committed
  85189a4

  Copy full SHA for 85189a4

• WIP: Start enhancing regression test and debugging.

  ryan-roemer

  committed
  fe90927

  Copy full SHA for fe90927

• WIP: Fix fixture stuff and get new error for 'yarn test' to run next

  ryan-roemer

  committed
  4312602

  Copy full SHA for 4312602

• Get tests back to passing state with skips, etc.

  ryan-roemer

  committed
  1d42e9b

  Copy full SHA for 1d42e9b

• Add more regression test skeletons

  ryan-roemer

  committed
  b948902

  Copy full SHA for b948902

Commits on Mar 14, 2019

• WIP: Getting closer to cache-based solution

  ryan-roemer

  committed
  ec38037

  Copy full SHA for ec38037

• Cleanup up and comment out WIP bugfix work for clean push.

  ryan-roemer

  committed
  6268b19

  Copy full SHA for 6268b19

• Experiment: Remove rootPath parameter

  ryan-roemer

  committed
  af184c8

  Copy full SHA for af184c8

Commits on Mar 15, 2019

• Add unit test for readPackages

  ryan-roemer

  committed
  a4601a5

  Copy full SHA for a4601a5

• Start adding _findPackage tests and remove resolves

  ryan-roemer

  committed
  23c748c

  Copy full SHA for 23c748c

• Add serial promise utility.

  ryan-roemer

  committed
  db2d2ec

  Copy full SHA for db2d2ec

• Switch to serial traversal

  ryan-roemer

  committed
  cf71cb8

  Copy full SHA for cf71cb8

• More comments

  ryan-roemer

  committed
  c8b6357

  Copy full SHA for c8b6357

• more envvar

  ryan-roemer

  committed
  564c598

  Copy full SHA for 564c598

• Get tests up and running with manually hacked in extra project root

  ryan-roemer

  committed
  0ae24a2

  Copy full SHA for 0ae24a2

• Various cleanup

  ryan-roemer

  committed
  7d8eb96

  Copy full SHA for 7d8eb96

Commits on Mar 16, 2019

• Start adding tests for _packageRoots

  ryan-roemer

  committed
  be36368

  Copy full SHA for be36368

• Add failing test

  ryan-roemer

  committed
  0a61c7c

  Copy full SHA for 0a61c7c

• Add more notes

  ryan-roemer

  committed
  6f6f879

  Copy full SHA for 6f6f879

• more notes

  ryan-roemer

  committed
  a251bda

  Copy full SHA for a251bda

• WIP/experiment with tempPotentialAppRoots

  ryan-roemer

  committed
  2dc042a

  Copy full SHA for 2dc042a

• WIP: More notes

  ryan-roemer

  committed
  c4dd88a

  Copy full SHA for c4dd88a

Commits on Mar 18, 2019

• Clean up _packageRoots

  ryan-roemer

  committed
  f554117

  Copy full SHA for f554117

• Refactor _packageRoots to be async

  ryan-roemer

  committed
  57a37fe

  Copy full SHA for 57a37fe

• Introspect potential roots for package.json

  ryan-roemer

  committed
  5b926ef

  Copy full SHA for 5b926ef

• Refactor to better names

  ryan-roemer

  committed
  2a671a8

  Copy full SHA for 2a671a8

• Note about mocking

  ryan-roemer

  committed
  871bba1

  Copy full SHA for 871bba1

• Make test win compatible

  ryan-roemer

  committed
  8d05fda

  Copy full SHA for 8d05fda

• Continue base refactoring / test work

  ryan-roemer

  committed
  b334b96

  Copy full SHA for b334b96

• Actually handle hidden application roots

  ryan-roemer

  committed
  a610b95

  Copy full SHA for a610b95

• Implement start of fix (unsorted still).

  ryan-roemer

  committed
  7840c9f

  Copy full SHA for 7840c9f

• Add skipped failing test

  ryan-roemer

  committed
  fd73d27

  Copy full SHA for fd73d27

• More todo notes

  ryan-roemer

  committed
  6511703

  Copy full SHA for 6511703

• Fix duplicate hidden roots issue

  ryan-roemer

  committed
  88c9566

  Copy full SHA for 88c9566

Commits on Mar 19, 2019

• Update travis urls post-migration

  ryan-roemer

  committed
  c4d3260

  Copy full SHA for c4d3260

• WIP for new app roots failing thing.

  ryan-roemer

  committed
  09d208d

  Copy full SHA for 09d208d

• More notes

  ryan-roemer

  committed
  1047361

  Copy full SHA for 1047361

Commits on Mar 20, 2019

• WIP: Normalize root paths, and check everything for package.json

  ryan-roemer

  committed
  a14c567

  Copy full SHA for a14c567

• WIP: Add more normalization and lint stuff

  ryan-roemer

  committed
  f6b2bde

  Copy full SHA for f6b2bde

• Only add unique modules to versions output

  ryan-roemer

  committed
  300b1a2

  Copy full SHA for 300b1a2

Commits on Mar 21, 2019

• Start adding tests and cleaning up TODOs

  ryan-roemer

  committed
  64fa435

  Copy full SHA for 64fa435

• Clean up TODOs

  ryan-roemer

  committed
  7415d52

  Copy full SHA for 7415d52

• More TODO cleanup

  ryan-roemer

  committed
  dd6763a

  Copy full SHA for dd6763a

• More cleanup

  ryan-roemer

  committed
  592a36c

  Copy full SHA for 592a36c

• more cleanup

  ryan-roemer

  committed
  54c49a5

  Copy full SHA for 54c49a5

• Move webpack token removal

  ryan-roemer

  committed
  25a6f8a

  Copy full SHA for 25a6f8a

Commits on Mar 22, 2019

• WIP: Broken. More common path work.

  ryan-roemer

  committed
  32caab0

  Copy full SHA for 32caab0

Commits on Mar 24, 2019

• Switch package roots to common root.

  ryan-roemer

  committed
  3e3a381

  Copy full SHA for 3e3a381

• Add commonRoot meta

  ryan-roemer

  committed
  275afad

  Copy full SHA for 275afad

• Implement test

  ryan-roemer

  committed
  e102e43

  Copy full SHA for e102e43

• Clean up todos

  ryan-roemer

  committed
  373be80

  Copy full SHA for 373be80

Commits on Mar 25, 2019

• Fix test

  ryan-roemer

  committed
  b3567ef

  Copy full SHA for b3567ef

• Add warning guardrails for expect vs actual matched sources for duplicateplugin.

  ryan-roemer

  committed
  1741c97

  Copy full SHA for 1741c97

• Make tests windows friendly

  ryan-roemer

  committed
  18bd729

  Copy full SHA for 18bd729