-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Handle null chunks in webpack stats object. #111
Conversation
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
==========================================
+ Coverage 90.56% 90.84% +0.28%
==========================================
Files 15 13 -2
Lines 763 732 -31
Branches 122 122
==========================================
- Hits 691 665 -26
+ Misses 41 36 -5
Partials 31 31
Continue to review full report at Codecov.
|
I'd be happy to test this out. What's a good way to push this into the workflow? I checked for an |
@westbrook-asapp -- Good point. I think I'll just release tomorrow and we can test it then 😛 (You could check it out, build the TS to JS, and manually drop into |
@ryan-roemer if you want to release a new version of |
I yolo-ed it. Released in |
Nice! @westbrook-asapp, I'll get a patch version of |
I can report that early signs here are very positive via a manual copy/paste of the inspectpack code @4.2.1. Look forward to the real thing in the morning. Thanks for you hard work on this, gentlemen. |
@westbrook-asapp v3.0.2 of |
This is working great on my end, thank you all! |
null
and handle in code. Fixes BUG: Webpack stats object failing type validation (Cannot load module/asset sizes.
) #110@westbrook-asapp - If you have a moment, want to try this one out? (No worries if not, I'm pretty sure this fixes the issue as your stats file now is parseable with this change. Thanks again so much for generating it -- it dramatically reduced the amount of time needed to fix this!)
/cc @parkerziegler