This repository was archived by the owner on Aug 19, 2022. It is now read-only.
deps: update karma-webpack #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current version of karma-webpack has a peer dependency conflict with the local version of webpack. This causes installs of this repo to fail with npm 7. Updating karma-webpack to ^3.0.0 resolves this conflict and all of the tests seem to still pass 🎉 There is a 4.x release of karma-webpack but I figured minimal improvement lowered the chance of breaking stuff
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of karma-webpack has a peer dependency
conflict with the local version of webpack. This causes
installs of this repo to fail with npm 7.
Updating karma-webpack to ^3.0.0 resolves this conflict and
all of the tests seem to still pass 🎉
There is a 4.x release of karma-webpack but I figured minimal
improvement lowered the chance of breaking stuff