Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controlled code props is not sync properly in 2.0.0 #130

Closed
ivan-dalmet opened this issue Apr 1, 2019 · 2 comments
Closed

Controlled code props is not sync properly in 2.0.0 #130

ivan-dalmet opened this issue Apr 1, 2019 · 2 comments

Comments

@ivan-dalmet
Copy link

ivan-dalmet commented Apr 1, 2019

react-live: 2.0.0

When editing the code from outside by passing it with the code property instead of using the built in LiveEditor, the rendering display the code with 1 input late.
docz-playground-edition-bug

You can see the Docz implementation here --> https://github.com/pedronauck/docz/blob/master/core/docz-theme-default/src/components/ui/Playground/index.tsx
(issue link in the docz repo: doczjs/docz#752)

If we rollback to the 1.12.0 this bug no longer exists.

Any idea why?

@sofiapoh
Copy link
Contributor

sofiapoh commented Apr 2, 2019

Hi, I think this is related to #127, I'll try to get a fix in asap!

sofiapoh pushed a commit that referenced this issue Apr 3, 2019
@sofiapoh
Copy link
Contributor

sofiapoh commented Apr 7, 2019

I've just released a patch with #132 which should fix this, let me know if there are still some problems!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants