Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the version of create-react-context #147

Merged
merged 2 commits into from
May 19, 2019

Conversation

gregorym
Copy link
Contributor

Version 0.2.3 of create-react-context does not have an MIT license. As a result, many companies are unable to use react-live. Between v0.2.2 and v0.2.3 only the license and the README has changed, it is safe to depend on v0.2.2 rather than v0.2.3.

Version 0.2.3 of `create-react-context` does not have an MIT license. As a result, many companies are unable to use `react-live`. Since between v0.2.2 and v0.2.3 only the license and the README has changed, it is safe to depend on `v0.2.2` rather than `v0.2.3`.
@ryan-roemer
Copy link
Member

Ah, good catch! master has been updated back to MIT (https://github.com/jamiebuilds/create-react-context/blob/master/LICENSE) but that hasn't been re-published.

@gregorym -- Can we change this to pin exactly to 0.2.2 a la:

"create-react-context": "0.2.2",

so that 0.2.3 can't get installed. Once create-react-context gets published off master then we'll switch to ^0.2.4 (or whatever that version is).

@gregorym
Copy link
Contributor Author

Done.

@ryan-roemer
Copy link
Member

Thanks @gregorym !!!

I'll leave it to @sofiapoh to see this one home as she's our lead.

@sofiapoh
Copy link
Contributor

Thanks @gregorym and @ryan-roemer!

@sofiapoh sofiapoh merged commit 72b00ca into FormidableLabs:master May 19, 2019
@gregorym
Copy link
Contributor Author

Thank you @sofiapoh. Will you be cutting a new release soon?

@sofiapoh
Copy link
Contributor

Yes, I'll release some time this afternoon!

@gregorym
Copy link
Contributor Author

Sorry to ping you again but I am blocked until a new version is released 😇

@sofiapoh
Copy link
Contributor

@gregorym
Copy link
Contributor Author

@sofiapoh Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants