fix: Handle NSNull in iosCustomBrowser param for logout

[seanfar]

Description

While there isn't an issue created specifically for what this PR is attempting to address, there are a few issues that seem to be related to it.

#1061 for example, which led to the fix introduced by #1064 addressed an issue on the authorize function.

Unfortunately, the logout function is still failing to properly display the browser, causing the flow to silently fail when iosCustomBrowser is not provided, as [self getCustomBrowser:NSNull] returned nil.

This seems to be happening on RN V0.77.1 with the new architecture enabled. Untested on other versions.

This PR adds a guard to fallback to the default external user agent when iosCustomBrowser is nil or NSNull.

Steps to verify

1. Configure the configuration object with no value for the iosCustomBrowser option that includes:

const config = {
  issuer: "https://youridprovider.com",
  clientId: "yourClientID",
  redirectUrl: "yourapp://callback",
  scopes: ["openid"],
  iosPrefersEphemeralSession: true,
  usePKCE: true,
};

2. Add the calls accordingly for authorize(config) and logout(config) in your code.
3. Build the app in iOS release mode.
4. Execute the authorize (login) and logout calls via your application.
5. Observe that the default browser is displayed properly.

[changeset-bot]

⚠️ No Changeset found

Latest commit: ee7a295

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-native-app-auth	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 25, 2025 5:01pm