Skip to content

Re-add additional params for backwards compatibility #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kadikraman merged 1 commit into from
Feb 18, 2019
Merged

Re-add additional params for backwards compatibility #250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ This is the result from the auth server
* **accessTokenExpirationDate** - (`string`) the token expiration date
* **authorizeAdditionalParameters** - (`Object`) additional url parameters from the authorizationEndpoint response.
* **tokenAdditionalParameters** - (`Object`) additional url parameters from the tokenEndpoint response.
* **additionalParameters** - (`Object`) :warning: _DEPRECATED_ legacy implementation. Will be removed in a future release. Returns just `tokenAdditionalParameters` for Android and `authorizeAdditionalParameters` on iOS
* **idToken** - (`string`) the id token
* **refreshToken** - (`string`) the refresh token
* **tokenType** - (`string`) the token type, e.g. Bearer
Expand Down
1 change: 1 addition & 0 deletions android/src/main/java/com/rnappauth/utils/TokenResponseFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ public static final WritableMap tokenResponseToMap(TokenResponse response, Autho
map.putString("accessToken", response.accessToken);
map.putMap("authorizeAdditionalParameters", createAdditionalParametersMap(authResponse.additionalParameters));
map.putMap("tokenAdditionalParameters", createAdditionalParametersMap(response.additionalParameters));
map.putMap("additionalParameters", createAdditionalParametersMap(response.additionalParameters)); // DEPRECATED
map.putString("idToken", response.idToken);
map.putString("refreshToken", response.refreshToken);
map.putString("tokenType", response.tokenType);
Expand Down
1 change: 1 addition & 0 deletions ios/RNAppAuth.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,7 @@ - (NSDictionary*)formatResponse: (OIDTokenResponse*) response
@"accessTokenExpirationDate": response.accessTokenExpirationDate ? [dateFormat stringFromDate:response.accessTokenExpirationDate] : @"",
@"authorizeAdditionalParameters": authResponse.additionalParameters,
@"tokenAdditionalParameters": response.additionalParameters,
@"additionalParameters": authResponse.additionalParameters, /* DEPRECATED */
@"idToken": response.idToken ? response.idToken : @"",
@"refreshToken": response.refreshToken ? response.refreshToken : @"",
@"tokenType": response.tokenType ? response.tokenType : @"",
Expand Down