Upgrade dependencies and remove styled-components workarounds #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With v5 they're not necessary anymore.
JoviDeCroock
approved these changes
Jan 17, 2020
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
==========================================
+ Coverage 96.91% 99.54% +2.62%
==========================================
Files 10 9 -1
Lines 487 442 -45
Branches 85 68 -17
==========================================
- Hits 472 440 -32
+ Misses 11 2 -9
+ Partials 4 0 -4
Continue to review full report at Codecov.
|
UberOpenSourceBot
pushed a commit
to fusionjs/fusionjs
that referenced
this pull request
Jan 21, 2020
As of FormidableLabs/react-ssr-prepass#39 (released in 1.1.0), react-ssr-prepass doesn't include any styled-components stuff, so we can safely use it without any missing/unused dependency errors. The only thing my fork did was comment out the styled-components stuff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.