Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container element should be configurable #24

Closed
nuthinking opened this issue Dec 16, 2015 · 7 comments
Closed

Container element should be configurable #24

nuthinking opened this issue Dec 16, 2015 · 7 comments

Comments

@nuthinking
Copy link

react-swiper had tagName for instance. I am pretty new to React I could implement it in the .js, not sure how to do it in the ,jsx

@hartzis
Copy link
Collaborator

hartzis commented Jan 1, 2016

I took a look at react-swiper, but I'm having trouble contemplating a use case where this is actually useful.

@nuthinking
Copy link
Author

In my case, I had a list of

  • and wanted each item to be swipe-able.

  • @sshmyg
    Copy link

    sshmyg commented Feb 2, 2016

    @nuthinking You can wrap content of your li into swipeable.

    @jcperez-ch
    Copy link

    @hartzis I believe what @nuthinking stated is a valid use case, where we should allow the user to configure the element so they can rely on existing css if the want to, instead of changing the css in fuction of this always present div.

    Not a big deal for many, but a huge one for others.

    @hartzis
    Copy link
    Collaborator

    hartzis commented Apr 21, 2016

    This seems reasonable, as long as the default stays 'div'.

    @pixelbreaker
    Copy link

    +1

    This is how react-tappable handles it, you can pass a component prop to it. Makes it much more flexible in different use cases.

    @hartzis
    Copy link
    Collaborator

    hartzis commented Jun 15, 2016

    Added nodeName prop with PR #40 to allow container to be configurable.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    No branches or pull requests

    5 participants