add configurable component container prop #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -30,7 +31,8 @@ const Swipeable = React.createClass({ | |||
| return { | |||
| flickThreshold: 0.6, | |||
| delta: 10, | |||
| preventDefaultTouchmoveEvent: true | |||
| preventDefaultTouchmoveEvent: true, | |||
| component: 'div' | |||
There was a problem hiding this comment.
should we name this nodeName instead or will ya'll accept a React component in here? If so, we should update the propTypes.
There was a problem hiding this comment.
I like nodeName, I used component due to conventions in other libraries, but I think some of those accept a react component. This won't accept a react component, there have not been expressed needs for this to accept an actual react component, yet.
There was a problem hiding this comment.
we can might as well make it accept a React component, there's no harm in allowing it.
hartzis
force-pushed
the
feature/component-container
branch
from
5e25c00 to
4e8ccf1
Compare
hartzis
force-pushed
the
feature/component-container
branch
from
4e8ccf1 to
0614970
Compare
|
@goatslacker thanks for the feedback, I updated the prop to |
|
LGTM |
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solution for #24. some ideas used from #36.
This is a non breaking, backwards compatible implementation. Will probably go out as v3.5.0.
I'd still like to update the api someday to do something close to #36, where it just attaches all the swiping props to what it is wrapping.