-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mention new graphql ppx instead of old one #119
Conversation
Mention new graphql ppx in docs and remove ppx from ppx_flags in bsconfig.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for this @huy-nguyen! Everything looks good on my end, just a few small suggested tweaks! I will also want to do some reading on graphql_ppx_re
today before merging just to validate that the library returns the same Js.t
shape from calling make
(i.e. query
, variables
, and parse
), since we rely on that heavily for proper type inference support. Appreciate you contributing ❤️
Fix small typos. Co-Authored-By: Parker Ziegler <parkerziegler@users.noreply.github.com>
Remove empty bsconfig.json field. Co-Authored-By: Parker Ziegler <parkerziegler@users.noreply.github.com>
Thanks again @huy-nguyen. The one thing that makes me a bit nervous about |
@all-contributors add @huy-nguyen for docs. |
I've put up a pull request to add @huy-nguyen! 🎉 |
Mention new graphql ppx in docs and remove ppx from ppx_flags in bsconfig. Fixes #117. Pinging @parkerziegler.