Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention new graphql ppx instead of old one #119

Merged
merged 3 commits into from
Nov 2, 2019
Merged

Mention new graphql ppx instead of old one #119

merged 3 commits into from
Nov 2, 2019

Conversation

huy-nguyen
Copy link
Contributor

Mention new graphql ppx in docs and remove ppx from ppx_flags in bsconfig. Fixes #117. Pinging @parkerziegler.

Mention new graphql ppx in docs
and remove ppx from ppx_flags in bsconfig.
bsconfig.json Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@parkerziegler parkerziegler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this @huy-nguyen! Everything looks good on my end, just a few small suggested tweaks! I will also want to do some reading on graphql_ppx_re today before merging just to validate that the library returns the same Js.t shape from calling make (i.e. query, variables, and parse), since we rely on that heavily for proper type inference support. Appreciate you contributing ❤️

huy-nguyen and others added 2 commits November 1, 2019 13:06
Fix small typos.

Co-Authored-By: Parker Ziegler <parkerziegler@users.noreply.github.com>
Remove empty bsconfig.json field.

Co-Authored-By: Parker Ziegler <parkerziegler@users.noreply.github.com>
@parkerziegler
Copy link
Contributor

Thanks again @huy-nguyen. The one thing that makes me a bit nervous about graphql_ppx_re are the unclear instructions about generating a graphql_schema.json, especially from a remote schema: https://github.com/baransu/graphql_ppx_re#usage One thing I really appreciate about graphql_ppx is that it's a one liner to get a schema from a remote server. I'll open an issue upstream asking for more clarification there. Thanks again for contributing!

@parkerziegler parkerziegler merged commit b229b5e into teamwalnut:master Nov 2, 2019
@parkerziegler
Copy link
Contributor

@all-contributors add @huy-nguyen for docs.

@allcontributors
Copy link
Contributor

@parkerziegler

I've put up a pull request to add @huy-nguyen! 🎉

@huy-nguyen huy-nguyen deleted the update-ppx-docs branch November 2, 2019 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to new GraphQL ppx
2 participants