This repository has been archived by the owner on May 11, 2023. It is now read-only.
fix: improve derivation of style for controller.set #112
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a small but important one! It improves the way we derive a
from
style to use for animations set off bycontroller.set
. The algorithm, with this change, becomes:style
property of the animating element.to
property specified incontroller.set
, use that value. It's very likely this value will have been set by a previous run of arenature
animation.to
property specified incontroller.set
, use the computed value. Computed values are always specified inpx
, so this is still an edge case where our animations fall a bit short. Would love for community contributors to help out with this piece!This brings us more in parity with how
d3
works, which is our sample reference point for this behind the scenes style derivation.