This repository has been archived by the owner on May 11, 2023. It is now read-only.
feat: pass physics values to onFrame callback #136
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fulfills a feature request from @littlemilkstudio.
The
onFrame
callback now receives theposition
,velocity
, andacceleration
values in addition to theprogress
value. ForuseGravity2D
, which never received aprogress
value because the orbit animation is infinite by nature,onFrame
also receives these vectors.This should make accessing these physics values for us in Three.js / r3f fairly trivial. The API would look something like the following for
useGravity2D
:For the other hooks, access will be slightly different.
progress
is the first argument passed toonFrame
. I didn't want to groupprogress
with the physics values to prevent a breaking API change.Hopefully this can be helpful for our Three.js shot! Let me know if there are some missing additional values that would be helpful here.