This repository has been archived by the owner on May 11, 2023. It is now read-only.
Fix transpilation of for of loops with Set caused by dangerousForOf in Buble config. #75
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a major 🐛 in v0.6.0. Previously, we had
dangerousForOf
enabled in our Buble transforms.dangerousForOf
assumes all structures being iterated withfor...of
loop are array-like objects with a length property 😱 . This doesn't work for us because we iterate over aSet
usingfor...of
.This PR adds in the necessary Babel transform to support IE11: https://babeljs.io/docs/en/babel-plugin-transform-for-of For now I'd like to keep IE11 support, but it is clear from the example that we end up adding a pretty hefty transpilation cost with this plugin. In a future release of
renature
(likely v1), we'll remove IE11 support entirely and strip this plugin. But for now, it makes sense to keep it in.