This repository has been archived by the owner on May 11, 2023. It is now read-only.
Fix #76. Ensure controller API only operates on elements animated by corresponding hook. #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkerziegler
requested review from
bmathews,
kitten,
maxyinger and
mariano-formidable
added 3 commits
July 26, 2020 12:36
parkerziegler
force-pushed
the
fix/controller-scope
branch
from
8ac8618 to
541003a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #76
This PR fixes a 🐛 introduced by v0.6.1. In the creation of our
use<Force>Grouphooks we introduced the concept of using aSetofanimatingElementsto manage handling multiple animating elements at once. This worked out great, but ourSetwas scoped at the module level rather than at the function level. This meant that, if you had multiplerenaturehooks running at the same time in the same React tree, thestop,start, andpausefunctions returned by any one of those hooks would act on all animating elements.This PR fixes that by moving our
animatingElementsSetinside of function scope. This means each hook gets its ownSetand manages its own instance ofrequestAnimationFrame. This is good – we want separate hook calls to maintain fully isolated state and behavior.There are a few additional changes in here to improve our types and begin to DRY out some of the behavior of these hooks to make it easier to maintain moving forward 💪 Hoping to shave a few bytes with these changes!