Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add ignoreExtensions option. #23

Merged
merged 9 commits into from
Nov 18, 2022

Conversation

ryan-roemer
Copy link
Member

@ryan-roemer ryan-roemer commented Nov 14, 2022

Note: This is in the docs, but worth highlighting -- an ignoreExtensions match is still included in the final zip bundle, it's just not parsed by trace-pkg/trace-deps any further. So if your configuration currently excludes *.graphql files then later adds them into the final zip file manually, you shouldn't do the latter part anymore.

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2022

Codecov Report

Merging #23 (a89956d) into main (40b863a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #23   +/-   ##
=======================================
  Coverage   98.88%   98.88%           
=======================================
  Files          18       18           
  Lines         717      719    +2     
=======================================
+ Hits          709      711    +2     
  Misses          8        8           
Impacted Files Coverage Δ
packages/trace-pkg/lib/config.js 96.87% <ø> (ø)
packages/trace-pkg/lib/worker/bundle.js 96.92% <ø> (ø)
packages/trace-deps/lib/trace.js 98.98% <100.00%> (+0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link

@carbonrobot carbonrobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice addition!

@paulmarsicloud
Copy link
Contributor

Works for me locally with this example:

options:
  ignores:
    - 'aws-sdk'
  ignoreExtensions:
    - 'graphql'

@ryan-roemer ryan-roemer merged commit aa98a36 into main Nov 18, 2022
@ryan-roemer ryan-roemer deleted the feature/handle-bad-extensions branch November 18, 2022 19:10
@github-actions github-actions bot mentioned this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

trace-pkg: Ignore custom extensions in tracing?
4 participants