-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add ignoreExtensions
option.
#23
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #23 +/- ##
=======================================
Coverage 98.88% 98.88%
=======================================
Files 18 18
Lines 717 719 +2
=======================================
+ Hits 709 711 +2
Misses 8 8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
carbonrobot
reviewed
Nov 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice addition!
Works for me locally with this example:
|
paulmarsicloud
approved these changes
Nov 18, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ignoreExtensions
option. Fixes trace-pkg: Ignore custom extensions in tracing? #18Note: This is in the docs, but worth highlighting -- an
ignoreExtensions
match is still included in the final zip bundle, it's just not parsed bytrace-pkg/trace-deps
any further. So if your configuration currently excludes*.graphql
files then later adds them into the final zip file manually, you shouldn't do the latter part anymore.