This repository was archived by the owner on Feb 19, 2022. It is now read-only.
Improve victoryInterpolator to handle more cases #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent d3 from attempting to interpolate values that don't make sense to interpolate, like: Boolean, NaN, Infinity, arbitrary class instances, etc. Change interpolation of such values to immediately jump to the end value, to match d3's behavior, instead of jumping at the halfway point. /cc @boygirl
|
cc/ @exogen looks good to me. Approved! |
exogen
added a commit
that referenced
this pull request
Oct 18, 2015
…vements Improve victoryInterpolator to handle more cases
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent d3 from attempting to interpolate values that don't make sense to interpolate, like: Boolean, NaN, Infinity, arbitrary class instances, etc. Change interpolation of such values to immediately jump to the end value, to match d3's behavior, instead of jumping at the halfway point.
/cc @boygirl