This repository has been archived by the owner on Feb 19, 2022. It is now read-only.
Remove bad interpolations #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fails CI on a test I'll look into that |
|
looks like CI broke on victory-chart similar to how it broke on victory-docs. I'll open a new issue. |
chrisbolin
force-pushed
the
remove-bad-interpolations
branch
from
76ed8b0 to
898daa1
Compare
…e "bundle" from VictoryArea
|
(fixed CI) |
|
Thanks! |
|
@boygirl i merged this, but then wasn't sure if you're comment was related to CI or to this PR. if you have concerns let me know (it's only a 3-line change) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes FormidableLabs/victory#558. Picking up the work from FormidableLabs/victory-core#258.