This repository has been archived by the owner on Feb 19, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modernizes the Victory build and offerings. Generally:
es/
directory alongsidelib/
that has ES module export / imports (but everything else babel built) per theredux
model. This model allows webpack2+ to use ESM resolution and enable tree-shaking, while is still backwards compatible with webpack1 which will uselib/
.jsx
since we don't use those anymore./cc @boygirl @chrisbolin
Cross-reference PRs
First, infrastructure:
Second, core:
Third, dependers:
Finally, parent:
Tickets
Implemented / fixed:
Opened / still open:
Bundles
The main goal here is not the victory bundle, but enabling webpack2+ users to get more efficient builds going off the
es/
directory. And with the dedupe plugin being removed in webpack2+, our dev bundle is definitely bigger. But, fortunately, the prod minified bundles aren't that different:Before / webpack1
After / webpack3