Upgrades ESLint to Version 9 (#2958)

config/webpack/demo/webpack.config.dev.js

@@ -5,7 +5,7 @@ const glob = require("glob");
 const LodashModuleReplacementPlugin = require("lodash-webpack-plugin");
 const ForkTsCheckerWebpackPlugin = require("fork-ts-checker-webpack-plugin");
 
-const ROOT = path.resolve(__dirname, "../../.."); // eslint-disable-line no-undef
+const ROOT = path.resolve(__dirname, "../../..");
 const PKGS = path.join(ROOT, "packages");
 const VICTORY_GLOB = path
   .join(PKGS, "victory*/package.json")
@@ -50,7 +50,7 @@ module.exports = {
         include: [DEMO],
         use: {
           loader: "babel-loader",
-          // eslint-disable-next-line global-require
+
           options: require("../../../.babelrc.js"),
         },
       },

config/webpack/demo/webpack.config.hot.js

@@ -5,7 +5,7 @@ const base = require("./webpack.config.dev");
 
 // Clone our own module object.
 const mod = _.cloneDeep(base.module);
-const firstLoader = mod.rules[0]; // eslint-disable-line no-magic-numbers
+const firstLoader = mod.rules[0];
 
 // Update rules array. First loader needs react-hot-loader.
 firstLoader.rules = [require.resolve("react-hot-loader")]

config/webpack/webpack.config.js

@@ -56,7 +56,7 @@ module.exports = {
         include: [SRC],
         use: {
           loader: "babel-loader",
-          // eslint-disable-next-line global-require
+
           options: require("../../.babelrc.js"),
         },
       },

demo/ts/app.tsx

@@ -289,4 +289,5 @@ class App extends React.Component<any, AppState> {
   }
 }
 
+// eslint-disable-next-line react/no-deprecated
 ReactDOM.render(<App />, document.getElementById("content"));

demo/ts/components/accessibility-demo.tsx

@@ -1,4 +1,4 @@
-/* eslint-disable no-magic-numbers */
+ 
 import React from "react";
 import { isNumber } from "lodash";
 import { VictoryGroup } from "victory-group";

demo/ts/components/animation-demo.tsx

@@ -1,4 +1,4 @@
-/* eslint-disable no-magic-numbers */
+ 
 import React from "react";
 import { random, range } from "lodash";
 import { VictoryBar } from "victory-bar";

demo/ts/components/canvas-demo.tsx

@@ -1,4 +1,4 @@
-/* eslint-disable no-magic-numbers */
+ 
 import React from "react";
 
 import { range, random } from "lodash";

demo/ts/components/create-container-demo.tsx

@@ -1,4 +1,4 @@
-/* eslint-disable no-magic-numbers,react/no-multi-comp */
+ 
 import React from "react";
 import { round } from "lodash";
 import { VictoryChart } from "victory-chart";

demo/ts/components/draggable-demo.tsx

@@ -1,4 +1,4 @@
-/* eslint-disable no-magic-numbers,react/no-multi-comp */
+ 
 
 import React from "react";
 import { VictoryChart } from "victory-chart";
@@ -36,6 +36,7 @@ interface DraggableDemoInterface {
 
 interface TargetPropsInterface {
   scale?: number;
+  // eslint-disable-next-line @typescript-eslint/no-unsafe-function-type
   onPointChange?: Function;
   datum?: {};
 }

demo/ts/components/events-demo.tsx

@@ -1,4 +1,4 @@
-/* eslint-disable no-magic-numbers */
+ 
 import React from "react";
 import { VictoryChart } from "victory-chart";
 import { VictoryStack } from "victory-stack";

demo/ts/components/external-events-demo.tsx

@@ -1,4 +1,4 @@
-/* eslint-disable no-magic-numbers */
+ 
 
 import React from "react";
 import { VictoryChart } from "victory-chart";

demo/ts/components/group-demo.tsx

@@ -1,4 +1,4 @@
-/* eslint-disable no-magic-numbers */
+ 
 import React from "react";
 import { VictoryChart } from "victory-chart";
 import { VictoryStack } from "victory-stack";

demo/ts/components/horizontal-demo.tsx

@@ -1,4 +1,4 @@
-/* eslint-disable no-magic-numbers */
+ 
 
 import React from "react";
 import { VictoryChart } from "victory-chart";

demo/ts/components/immutable-demo.tsx

@@ -1,4 +1,4 @@
-/* eslint-disable no-magic-numbers, react/no-multi-comp */
+ 
 import React from "react";
 import { keys, random, range, round } from "lodash";
 import { fromJS } from "immutable";
@@ -20,7 +20,6 @@ import { VictorySelectionContainer } from "victory-selection-container";
 import { VictoryCursorContainer } from "victory-cursor-container";
 import { VictoryBrushContainer } from "victory-brush-container";
 import { VictoryTooltip } from "victory-tooltip";
-import { VictoryLegend } from "victory-legend";
 import {
   DomainTuple,
   VictoryClipContainer,
@@ -105,7 +104,7 @@ export default class ImmutableDemo extends React.Component<
   }
 
   componentDidMount() {
-    /* eslint-disable react/no-did-mount-set-state */
+     
     this.setStateInterval = window.setInterval(() => {
       this.setState({
         scatterData: this.getScatterData(),

demo/ts/components/primitives-demo.tsx

@@ -1,4 +1,4 @@
-/* eslint-disable no-magic-numbers */
+ 
 import React from "react";
 
 import { VictoryAxis } from "victory-axis";

demo/ts/components/selection-demo.tsx

@@ -1,4 +1,4 @@
-/* eslint-disable no-magic-numbers */
+ 
 import React from "react";
 import { VictoryChart } from "victory-chart";
 import { VictoryStack } from "victory-stack";

demo/ts/components/victory-axis-demo.tsx

@@ -24,7 +24,7 @@ export default class VictoryAxisDemo extends React.Component<
   }
 
   componentDidMount() {
-    /* eslint-disable react/no-did-mount-set-state */
+     
     this.setStateInterval = window.setInterval(() => {
       this.setState({
         tickValues: this.getTickValues(),

demo/ts/components/victory-box-plot-demo.tsx

@@ -1,4 +1,4 @@
-/* eslint-disable no-magic-numbers */
+ 
 import React from "react";
 import { VictoryChart } from "victory-chart";
 import { VictoryBoxPlot } from "victory-box-plot";

demo/ts/components/victory-brush-container-demo.tsx

@@ -1,4 +1,4 @@
-/* eslint-disable no-magic-numbers */
+ 
 import React from "react";
 import { VictoryChart } from "victory-chart";
 import { VictoryStack } from "victory-stack";

demo/ts/components/victory-brush-line-demo.tsx

@@ -1,5 +1,5 @@
-/* eslint-disable no-magic-numbers */
-/* eslint-disable no-shadow */
+ 
+ 
 
 import React from "react";
 import { VictoryChart } from "victory-chart";

demo/ts/components/victory-candlestick-demo.tsx

@@ -1,6 +1,4 @@
-/* eslint-disable no-magic-numbers */
 import React from "react";
-import { random, range } from "lodash";
 import { VictoryChart } from "victory-chart";
 import { VictoryCandlestick } from "victory-candlestick";
 import { VictoryTheme } from "victory-core";
@@ -18,30 +16,6 @@ interface VictoryCandlestickDemoState {
   }[];
 }
 
-const getData = () => {
-  const colors = [
-    "violet",
-    "cornflowerblue",
-    "gold",
-    "orange",
-    "turquoise",
-    "tomato",
-    "greenyellow",
-  ];
-  return range(50).map(() => {
-    return {
-      x: random(600),
-      open: random(600),
-      close: random(600),
-      high: random(450, 600),
-      low: random(0, 150),
-      size: random(15) + 3,
-      fill: colors[random(0, 6)],
-      opacity: random(0.3, 1),
-    };
-  });
-};
-
 const containerStyle: React.CSSProperties = {
   display: "flex",
   flexDirection: "row",

demo/ts/components/victory-chart-demo.tsx

@@ -12,7 +12,6 @@ import {
   VictoryLabel,
   VictoryTheme,
   VictoryClipContainer,
-  VictoryThemeDefinition,
   VictoryThemePalette,
 } from "victory-core";
 
@@ -41,13 +40,6 @@ class Wrapper extends React.Component<WrapperProps> {
   }
 }
 
-const dependentAxisTheme: VictoryThemeDefinition = {
-  ...VictoryTheme.material,
-  dependentAxis: {
-    orientation: "right",
-  },
-};
-
 type XYNumberType = {
   x: number | string;
   y: number | string;
@@ -87,7 +79,7 @@ class VictoryChartDemo extends React.Component<any, VictoryChartDemoState> {
   }
 
   componentDidMount() {
-    /* eslint-disable react/no-did-mount-set-state */
+     
     this.setStateInterval = window.setInterval(() => {
       this.setState({
         scatterData: this.getScatterData(),