Fix label measurement after SSR hydration mismatch (#2626)

Co-authored-by: Charlie Brown <carbonrobot@gmail.com>
FormidableLabs · Jan 8, 2024 · e7393a9 · e7393a9 · vercel · Jan 8, 2024
1 parent 583e837
commit e7393a9
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/.changeset/tender-insects-rest.md b/.changeset/tender-insects-rest.md
@@ -0,0 +1,5 @@
+---
+"victory-core": patch
+---
+
+Fix text label measurements after SSR hydration mismatch
diff --git a/packages/victory-core/src/victory-util/textsize.ts b/packages/victory-core/src/victory-util/textsize.ts
@@ -297,7 +297,11 @@ const styleToKeyComponent = (style) => {
 
 const _measureDimensionsInternal = memoize(
  (text: string | string[], style?: TextSizeStyleInterface) => {
- const containerElement = _getMeasurementContainer();
+ let containerElement = _getMeasurementContainer();
+ if (!containerElement.isConnected) {
+ _getMeasurementContainer.cache.clear?.();
+ containerElement = _getMeasurementContainer();
+ }
 
  const lines = _splitToLines(text);
  let heightAcc = 0;