Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VictoryBrushContainer: brush disappears even when defaultBrushArea set to disable #1058

Closed
4 tasks done
ddai85 opened this issue Jul 25, 2018 · 4 comments
Closed
4 tasks done
Labels
Status: Help Wanted 🔨 Extra attention is needed Type: Bug 🐛 Oh no! A bug or unintentional behavior

Comments

@ddai85
Copy link

ddai85 commented Jul 25, 2018

Bugs and Questions

Checklist

  • This is not a victory-native specific issue. (Issues that only appear in victory-native should be opened here)

  • I have read through the FAQ and Guides before asking a question

  • I am using the latest version of Victory

  • I've searched open issues to make sure I'm not opening a duplicate issue

The Problem

When props for VictoryBrushContainer are set as:
defaultBrushArea="disable brushDimension="x" allowResize={false}
brush disappears onMouseDown that is not on the brush itself. Expected behavior for defaultBrushArea="disable" should be for the brush to remain at same brush domain.

Reproduction

Bug is reproduced here:

https://codesandbox.io/s/kky0qz6pvr

@ddai85
Copy link
Author

ddai85 commented Jul 25, 2018

nevermind, don't need brushDimension prop if not resizing

@ddai85 ddai85 closed this as completed Jul 25, 2018
@dsc8x
Copy link

dsc8x commented Aug 26, 2018

This is still a bug, can we re-open this ticket? :)

@becca-bailey
Copy link
Contributor

Confirmed that this is still reproducible in the latest version of Victory.

@becca-bailey becca-bailey added Type: Bug 🐛 Oh no! A bug or unintentional behavior Status: Help Wanted 🔨 Extra attention is needed labels Feb 15, 2022
@becca-bailey
Copy link
Contributor

Closing in favor of #2111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Help Wanted 🔨 Extra attention is needed Type: Bug 🐛 Oh no! A bug or unintentional behavior
Projects
None yet
Development

No branches or pull requests

4 participants