Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and fix brush and zoom behavior #2111

Closed
becca-bailey opened this issue Feb 15, 2022 · 4 comments
Closed

Refactor and fix brush and zoom behavior #2111

becca-bailey opened this issue Feb 15, 2022 · 4 comments
Labels
Issue: Accepted The submitted issue has been confirmed by the Victory core team Status: On Hold ⚠️ This issue has prerequisites before it can be addressed Type: Enhancement ✏️ An enhancement or feature proposal that will be addressed after the next release

Comments

@becca-bailey
Copy link
Contributor

becca-bailey commented Feb 15, 2022

We have seen lots of issues come up around brush and zoom behavior, and the brush and zoom becoming out of sync in certain situations. Since it has been difficult to address this issues, VictoryZoomContainer is a good candidate for a refactor.

Let's consolidate some of the discussion around VictoryBrush and VictoryZoomContainer here in order to avoid duplicate issues.

Current issues:

This issue most likely depends on the state management milestone.

@becca-bailey becca-bailey added Type: Bug 🐛 Oh no! A bug or unintentional behavior Type: Enhancement ✏️ An enhancement or feature proposal that will be addressed after the next release labels Feb 15, 2022
@becca-bailey becca-bailey removed the Type: Bug 🐛 Oh no! A bug or unintentional behavior label Feb 15, 2022
@becca-bailey becca-bailey added the Status: On Hold ⚠️ This issue has prerequisites before it can be addressed label Feb 15, 2022
@siulca
Copy link

siulca commented Jul 1, 2022

Probably should be looking into this one too since this is being refactored.
#2340

@micmcg
Copy link

micmcg commented Jun 13, 2023

Any update on the Zoom and Brush refactor @becca-bailey? Thanks

@Parker-Stafford
Copy link

Also curious about any updates here @becca-bailey, experiencing the exact same issue as described here #1541, brushDomain is fully controlled, upon programmatically setting it, the brush does not re-render. The brushDomain is properly updating but x, y, and width values in BrushHandleComponent and BrushComponent are not updating.

@carbonrobot carbonrobot added the Issue: Accepted The submitted issue has been confirmed by the Victory core team label Feb 23, 2024
@carbonrobot
Copy link
Contributor

This issue scope has expanded greatly, but all the PRs appeared to be merged. I'm going to close this one and we can address any remaining problems in separate issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Accepted The submitted issue has been confirmed by the Victory core team Status: On Hold ⚠️ This issue has prerequisites before it can be addressed Type: Enhancement ✏️ An enhancement or feature proposal that will be addressed after the next release
Projects
None yet
Development

No branches or pull requests

5 participants