Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript errors since 36.8.6 version #2784

Closed
TomCorvus opened this issue Feb 6, 2024 · 1 comment
Closed

TypeScript errors since 36.8.6 version #2784

TomCorvus opened this issue Feb 6, 2024 · 1 comment
Assignees
Labels
Type: Bug 🐛 Oh no! A bug or unintentional behavior Type: TypeScript Issues related to typescript or type definitions

Comments

@TomCorvus
Copy link

Describe the bug
Since 36.8.6 version, I have TypeScript errors on multiple props with victory-native components.

Victory version
36.8.6 or 36.9.0

Code Sandbox link

<VictoryLine
	data={data}
	name="line1"
	interpolation="monotoneX"
	style={{
		labels: { fill: palette.bubblegum.bubblegum50 },
		data: { stroke: palette.bubblegum.bubblegum50 },
	}}
/>;

OR

<VictoryVoronoiContainer
	onTouchStart={() => onTouchStartHandler()}
	onTouchEnd={() => onTouchEndHandler()}
	voronoiBlacklist={['scatter1', 'scatter2']}
	voronoiDimension="x"
/>;

To Reproduce
In code above, onTouchStart, onTouchEnd, data, name, interpolation, style generate TS errors.
I didn't check others charts.

Expected behavior
No TS errors.

Screenshots
Not applicable

Additional context
TypeScript ^5.3.3

@KenanYusuf KenanYusuf self-assigned this Feb 6, 2024
@KenanYusuf KenanYusuf added Type: Bug 🐛 Oh no! A bug or unintentional behavior Type: TypeScript Issues related to typescript or type definitions labels Feb 6, 2024
@carbonrobot
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug 🐛 Oh no! A bug or unintentional behavior Type: TypeScript Issues related to typescript or type definitions
Projects
None yet
Development

No branches or pull requests

3 participants