Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Relates to #2784
There were a couple of issues with the types in the
victory-native
package, caused by #2739.Wrapped components
Components that were wrapped with the
wrapCoreComponent
HOC were only accepting props that were passed to the defaultProps object. For example:I have updated this by ensuring that the base component's props are passed as a generic to the
wrapCoreComponent
function:Container components
The
victory-*-container
component props were being typed incorrectly as the type of the original component props. For example:In the above example,
VictoryVoronoiContainerBase
is thetypeof
the base victory component. To fix this, the types were updated so that the return type ofcombinedMixin
is a class component with the props for thevictory-native
version: